diff options
| author | phk <phk@FreeBSD.org> | 2002-10-25 08:40:20 +0000 |
|---|---|---|
| committer | phk <phk@FreeBSD.org> | 2002-10-25 08:40:20 +0000 |
| commit | b6e6ea6570e4a7a4fa7113407d6aeee72e99d9a1 (patch) | |
| tree | d6d399d80253ddb98f5494e7c7d421f90b2e8483 /sys | |
| parent | f49bd854f39103632ab22e45c4165d95f96dfaea (diff) | |
| download | FreeBSD-src-b6e6ea6570e4a7a4fa7113407d6aeee72e99d9a1.zip FreeBSD-src-b6e6ea6570e4a7a4fa7113407d6aeee72e99d9a1.tar.gz | |
Disable the kernacc() check in mtx_validate() until such time that kernacc
does not require Giant.
This means that we may miss panics on a class of mutex programming bugs,
but only if running with a Chernobyl setting of debug-flags.
Spotted by: Pete Carah <pete@ns.altadena.net>
Diffstat (limited to 'sys')
| -rw-r--r-- | sys/kern/kern_mutex.c | 5 | ||||
| -rw-r--r-- | sys/kern/subr_turnstile.c | 5 |
2 files changed, 10 insertions, 0 deletions
diff --git a/sys/kern/kern_mutex.c b/sys/kern/kern_mutex.c index a52e25a..1a32471 100644 --- a/sys/kern/kern_mutex.c +++ b/sys/kern/kern_mutex.c @@ -859,6 +859,10 @@ mtx_validate(struct mtx *m) { /* + * XXX: When kernacc() does not require Giant we can reenable this check + */ +#ifdef notyet +/* * XXX - When kernacc() is fixed on the alpha to handle K0_SEG memory properly * we can re-enable the kernacc() checks. */ @@ -873,6 +877,7 @@ mtx_validate(struct mtx *m) VM_PROT_READ | VM_PROT_WRITE)) panic("Can't read and write to mutex %p", m); #endif +#endif } #endif diff --git a/sys/kern/subr_turnstile.c b/sys/kern/subr_turnstile.c index a52e25a..1a32471 100644 --- a/sys/kern/subr_turnstile.c +++ b/sys/kern/subr_turnstile.c @@ -859,6 +859,10 @@ mtx_validate(struct mtx *m) { /* + * XXX: When kernacc() does not require Giant we can reenable this check + */ +#ifdef notyet +/* * XXX - When kernacc() is fixed on the alpha to handle K0_SEG memory properly * we can re-enable the kernacc() checks. */ @@ -873,6 +877,7 @@ mtx_validate(struct mtx *m) VM_PROT_READ | VM_PROT_WRITE)) panic("Can't read and write to mutex %p", m); #endif +#endif } #endif |
