diff options
| author | marius <marius@FreeBSD.org> | 2011-11-22 21:28:20 +0000 |
|---|---|---|
| committer | marius <marius@FreeBSD.org> | 2011-11-22 21:28:20 +0000 |
| commit | 17e14c6132be998c8e8d0c2fc89ff0b66d24999c (patch) | |
| tree | 4941db3a873a5f9b2ccc4a64c23bf5cd65516206 /sys/x86 | |
| parent | 6479d45e1526c99672febf3a29a6a99305871131 (diff) | |
| download | FreeBSD-src-17e14c6132be998c8e8d0c2fc89ff0b66d24999c.zip FreeBSD-src-17e14c6132be998c8e8d0c2fc89ff0b66d24999c.tar.gz | |
- There's no need to overwrite the default device method with the default
one. Interestingly, these are actually the default for quite some time
(bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9)
since r52045) but even recently added device drivers do this unnecessarily.
Discussed with: jhb, marcel
- While at it, use DEVMETHOD_END.
Discussed with: jhb
- Also while at it, use __FBSDID.
Diffstat (limited to 'sys/x86')
| -rw-r--r-- | sys/x86/pci/pci_bus.c | 3 | ||||
| -rw-r--r-- | sys/x86/pci/qpi.c | 3 | ||||
| -rw-r--r-- | sys/x86/x86/mptable_pci.c | 3 |
3 files changed, 3 insertions, 6 deletions
diff --git a/sys/x86/pci/pci_bus.c b/sys/x86/pci/pci_bus.c index 0efac6e..995e714 100644 --- a/sys/x86/pci/pci_bus.c +++ b/sys/x86/pci/pci_bus.c @@ -597,7 +597,6 @@ static device_method_t legacy_pcib_methods[] = { DEVMETHOD(device_resume, bus_generic_resume), /* Bus interface */ - DEVMETHOD(bus_print_child, bus_generic_print_child), DEVMETHOD(bus_read_ivar, legacy_pcib_read_ivar), DEVMETHOD(bus_write_ivar, legacy_pcib_write_ivar), DEVMETHOD(bus_alloc_resource, legacy_pcib_alloc_resource), @@ -619,7 +618,7 @@ static device_method_t legacy_pcib_methods[] = { DEVMETHOD(pcib_release_msix, pcib_release_msix), DEVMETHOD(pcib_map_msi, legacy_pcib_map_msi), - { 0, 0 } + DEVMETHOD_END }; static devclass_t hostb_devclass; diff --git a/sys/x86/pci/qpi.c b/sys/x86/pci/qpi.c index d14494c..08a95f5 100644 --- a/sys/x86/pci/qpi.c +++ b/sys/x86/pci/qpi.c @@ -292,7 +292,6 @@ static device_method_t qpi_pcib_methods[] = { DEVMETHOD(device_resume, bus_generic_resume), /* Bus interface */ - DEVMETHOD(bus_print_child, bus_generic_print_child), DEVMETHOD(bus_read_ivar, qpi_pcib_read_ivar), DEVMETHOD(bus_alloc_resource, bus_generic_alloc_resource), DEVMETHOD(bus_release_resource, bus_generic_release_resource), @@ -311,7 +310,7 @@ static device_method_t qpi_pcib_methods[] = { DEVMETHOD(pcib_release_msix, pcib_release_msix), DEVMETHOD(pcib_map_msi, qpi_pcib_map_msi), - {0, 0} + DEVMETHOD_END }; static devclass_t qpi_pcib_devclass; diff --git a/sys/x86/x86/mptable_pci.c b/sys/x86/x86/mptable_pci.c index f0b90a8..985cfa7 100644 --- a/sys/x86/x86/mptable_pci.c +++ b/sys/x86/x86/mptable_pci.c @@ -190,7 +190,6 @@ static device_method_t mptable_hostb_methods[] = { DEVMETHOD(device_resume, bus_generic_resume), /* Bus interface */ - DEVMETHOD(bus_print_child, bus_generic_print_child), DEVMETHOD(bus_read_ivar, legacy_pcib_read_ivar), DEVMETHOD(bus_write_ivar, legacy_pcib_write_ivar), #ifdef NEW_PCIB @@ -217,7 +216,7 @@ static device_method_t mptable_hostb_methods[] = { DEVMETHOD(pcib_release_msix, pcib_release_msix), DEVMETHOD(pcib_map_msi, mptable_hostb_map_msi), - { 0, 0 } + DEVMETHOD_END }; static devclass_t hostb_devclass; |
