summaryrefslogtreecommitdiffstats
path: root/sys/vm
diff options
context:
space:
mode:
authormav <mav@FreeBSD.org>2013-11-19 10:17:10 +0000
committermav <mav@FreeBSD.org>2013-11-19 10:17:10 +0000
commit073851700eea204c35444e48223db6c06db43f25 (patch)
treebf693377e40d9c3f10a83ba2075f25e7172fc6b5 /sys/vm
parent3e43d6e71a200cf40394cebc1390d3a840d5049f (diff)
downloadFreeBSD-src-073851700eea204c35444e48223db6c06db43f25.zip
FreeBSD-src-073851700eea204c35444e48223db6c06db43f25.tar.gz
Grow UMA zone bucket size also on lock congestion during item free.
Lock congestion is the same, whether it happens on alloc or free, so handle it equally. Now that we have back pressure, there is no problem to grow buckets a bit faster. Any way growth is much slower then in 9.x.
Diffstat (limited to 'sys/vm')
-rw-r--r--sys/vm/uma_core.c15
1 files changed, 13 insertions, 2 deletions
diff --git a/sys/vm/uma_core.c b/sys/vm/uma_core.c
index 6f816b2..20a1bf6 100644
--- a/sys/vm/uma_core.c
+++ b/sys/vm/uma_core.c
@@ -2529,6 +2529,7 @@ uma_zfree_arg(uma_zone_t zone, void *item, void *udata)
{
uma_cache_t cache;
uma_bucket_t bucket;
+ int lockfail;
int cpu;
#ifdef UMA_DEBUG_ALLOC_1
@@ -2613,7 +2614,12 @@ zfree_start:
if (zone->uz_count == 0 || bucketdisable)
goto zfree_item;
- ZONE_LOCK(zone);
+ lockfail = 0;
+ if (ZONE_TRYLOCK(zone) == 0) {
+ /* Record contention to size the buckets. */
+ ZONE_LOCK(zone);
+ lockfail = 1;
+ }
critical_enter();
cpu = curcpu;
cache = &zone->uz_cpu[cpu];
@@ -2647,7 +2653,12 @@ zfree_start:
/* We are no longer associated with this CPU. */
critical_exit();
- /* And the zone.. */
+ /*
+ * We bump the uz count when the cache size is insufficient to
+ * handle the working set.
+ */
+ if (lockfail && zone->uz_count < BUCKET_MAX)
+ zone->uz_count++;
ZONE_UNLOCK(zone);
#ifdef UMA_DEBUG_ALLOC
OpenPOWER on IntegriCloud