Fix up some sloppy coding practices:

- Delete redundant declarations.
- Add -Wredundant-declarations to Makefile.i386 so they don't come back.
- Delete sloppy COMMON-style declarations of uninitialized data in
  header files.
- Add a few prototypes.
- Clean up warnings resulting from the above.

NB: ioconf.c will still generate a redundant-declaration warning, which
is unavoidable unless somebody volunteers to make `config' smarter.

4 files changed, 4 insertions, 10 deletions

diff --git a/sys/ufs/ffs/ffs_extern.h b/sys/ufs/ffs/ffs_extern.h
index 9b1bb50..ee2a3c1 100644
--- a/sys/ufs/ffs/ffs_extern.h
+++ b/sys/ufs/ffs/ffs_extern.h
@@ -31,7 +31,7 @@
  * SUCH DAMAGE.
  *
  *	@(#)ffs_extern.h	8.3 (Berkeley) 4/16/94
- * $Id$
+ * $Id: ffs_extern.h,v 1.3 1994/08/02 07:54:19 davidg Exp $
  */
 
 struct buf;
@@ -85,8 +85,6 @@ int	ffs_vget __P((struct mount *, ino_t, struct vnode **));
 int	ffs_vptofh __P((struct vnode *, struct fid *));
 int	ffs_write __P((struct vop_write_args *));
 
-int	bwrite();		/* FFS needs a bwrite routine.  XXX */
-
 #ifdef DIAGNOSTIC
 void	ffs_checkoverlap __P((struct buf *, struct inode *));
 #endif
diff --git a/sys/ufs/ffs/ffs_vfsops.c b/sys/ufs/ffs/ffs_vfsops.c
index def856c..bd1ad2b 100644
--- a/sys/ufs/ffs/ffs_vfsops.c
+++ b/sys/ufs/ffs/ffs_vfsops.c
@@ -31,7 +31,7 @@
  * SUCH DAMAGE.
  *
  *	@(#)ffs_vfsops.c	8.8 (Berkeley) 4/18/94
- * $Id$
+ * $Id: ffs_vfsops.c,v 1.3 1994/08/02 07:54:24 davidg Exp $
  */
 
 #include <sys/param.h>
@@ -88,7 +88,6 @@ extern u_long nextgennumber;
 int
 ffs_mountroot()
 {
-	extern struct vnode *rootvp;
 	register struct fs *fs;
 	register struct mount *mp;
 	struct proc *p = curproc;	/* XXX */
@@ -350,7 +349,6 @@ ffs_mountfs(devvp, mp, p)
 	int havepart = 0, blks;
 	int error, i, size;
 	int ronly;
-	extern struct vnode *rootvp;
 
 	/*
 	 * Disallow multiple mounts of the same device.
diff --git a/sys/ufs/mfs/mfs_vfsops.c b/sys/ufs/mfs/mfs_vfsops.c
index 9238fb3..9d0259d 100644
--- a/sys/ufs/mfs/mfs_vfsops.c
+++ b/sys/ufs/mfs/mfs_vfsops.c
@@ -31,7 +31,7 @@
  * SUCH DAMAGE.
  *
  *	@(#)mfs_vfsops.c	8.4 (Berkeley) 4/16/94
- * $Id$
+ * $Id: mfs_vfsops.c,v 1.3 1994/08/02 07:54:43 davidg Exp $
  */
 
 #include <sys/param.h>
@@ -90,7 +90,6 @@ struct vfsops mfs_vfsops = {
 int
 mfs_mountroot()
 {
-	extern struct vnode *rootvp;
 	register struct fs *fs;
 	register struct mount *mp;
 	struct proc *p = curproc;	/* XXX */
diff --git a/sys/ufs/ufs/ufs_inode.c b/sys/ufs/ufs/ufs_inode.c
index 567f303..5ca9bc9 100644
--- a/sys/ufs/ufs/ufs_inode.c
+++ b/sys/ufs/ufs/ufs_inode.c
@@ -36,7 +36,7 @@
  * SUCH DAMAGE.
  *
  *	@(#)ufs_inode.c	8.4 (Berkeley) 1/21/94
- * $Id$
+ * $Id: ufs_inode.c,v 1.2 1994/08/02 07:54:56 davidg Exp $
  */
 
 #include <sys/param.h>
@@ -86,7 +86,6 @@ ufs_inactive(ap)
 	register struct inode *ip = VTOI(vp);
 	struct timeval tv;
 	int mode, error;
-	extern int prtactive;
 
 	if (prtactive && vp->v_usecount != 0)
 		vprint("ffs_inactive: pushing active", vp);