diff options
| author | mckusick <mckusick@FreeBSD.org> | 2013-05-22 00:40:26 +0000 |
|---|---|---|
| committer | mckusick <mckusick@FreeBSD.org> | 2013-05-22 00:40:26 +0000 |
| commit | bcfba66af4aa212825db2fc63258f430609eb928 (patch) | |
| tree | 553816f49a236af2c7e8859dbc126f53e7393666 /sys/ufs | |
| parent | ef9c2a57440d1b144dda56e91632cf15642a55b8 (diff) | |
| download | FreeBSD-src-bcfba66af4aa212825db2fc63258f430609eb928.zip FreeBSD-src-bcfba66af4aa212825db2fc63258f430609eb928.tar.gz | |
Null a pointer after it is freed so that when it is returned
the return value is NULL. Based on the returned flags, the
return value should never be inspected in the case where NULL
is returned, but it is good coding practice not to return a
pointer to freed memory.
Found by: Coverity Scan, CID 1006096
Reviewed by: kib
MFC after: 2 weeks
Diffstat (limited to 'sys/ufs')
| -rw-r--r-- | sys/ufs/ffs/ffs_softdep.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c index af4f7c4..788b755 100644 --- a/sys/ufs/ffs/ffs_softdep.c +++ b/sys/ufs/ffs/ffs_softdep.c @@ -8150,6 +8150,7 @@ setup_newdir(dap, newinum, dinum, newdirbp, mkdirp) (inodedep->id_state & ALLCOMPLETE) == ALLCOMPLETE) { dap->da_state &= ~MKDIR_PARENT; WORKITEM_FREE(mkdir2, D_MKDIR); + mkdir2 = NULL; } else { LIST_INSERT_HEAD(&mkdirlisthd, mkdir2, md_mkdirs); WORKLIST_INSERT(&inodedep->id_bufwait, &mkdir2->md_list); |
