diff options
| author | tegge <tegge@FreeBSD.org> | 2006-09-26 04:12:49 +0000 |
|---|---|---|
| committer | tegge <tegge@FreeBSD.org> | 2006-09-26 04:12:49 +0000 |
| commit | 83154f853d9ca39deb1add01e032aff1f0678514 (patch) | |
| tree | ac46e0b5a80f88127d3d14dc940a5f2746573c00 /sys/ufs/ffs/ffs_snapshot.c | |
| parent | d7fe3e736512a1dd37a985037184eecf7df1f26d (diff) | |
| download | FreeBSD-src-83154f853d9ca39deb1add01e032aff1f0678514.zip FreeBSD-src-83154f853d9ca39deb1add01e032aff1f0678514.tar.gz | |
Use mount interlock to protect all changes to mnt_flag and mnt_kern_flag.
This eliminates a race where MNT_UPDATE flag could be lost when nmount()
raced against sync(), sync_fsync() or quotactl().
Diffstat (limited to 'sys/ufs/ffs/ffs_snapshot.c')
| -rw-r--r-- | sys/ufs/ffs/ffs_snapshot.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/sys/ufs/ffs/ffs_snapshot.c b/sys/ufs/ffs/ffs_snapshot.c index b183569..f23f098 100644 --- a/sys/ufs/ffs/ffs_snapshot.c +++ b/sys/ufs/ffs/ffs_snapshot.c @@ -194,7 +194,7 @@ ffs_snapshot(mp, snapfile) ufs2_daddr_t numblks, blkno, *blkp, *snapblklist; int error, cg, snaploc; int i, size, len, loc; - int flag = mp->mnt_flag; + int flag; struct timespec starttime = {0, 0}, endtime; char saved_nice = 0; long redo = 0, snaplistsize = 0; @@ -216,6 +216,9 @@ ffs_snapshot(mp, snapfile) ump = VFSTOUFS(mp); fs = ump->um_fs; sn = NULL; + MNT_ILOCK(mp); + flag = mp->mnt_flag; + MNT_IUNLOCK(mp); /* * Need to serialize access to snapshot code per filesystem. @@ -828,7 +831,9 @@ out: fs->fs_active = 0; } UFS_UNLOCK(ump); + MNT_ILOCK(mp); mp->mnt_flag = flag; + MNT_IUNLOCK(mp); if (error) (void) ffs_truncate(vp, (off_t)0, 0, NOCRED, td); (void) ffs_syncvnode(vp, MNT_WAIT); |
