diff options
author | rwatson <rwatson@FreeBSD.org> | 2007-03-04 22:36:48 +0000 |
---|---|---|
committer | rwatson <rwatson@FreeBSD.org> | 2007-03-04 22:36:48 +0000 |
commit | 300d4098cfd89ed7f8fca1a3333256308124f41b (patch) | |
tree | f27b57bdc76f93b33f438468bf58343b920adf0f /sys/security | |
parent | cabb128e116189b28979fed24ecb43c60be0ffcf (diff) | |
download | FreeBSD-src-300d4098cfd89ed7f8fca1a3333256308124f41b.zip FreeBSD-src-300d4098cfd89ed7f8fca1a3333256308124f41b.tar.gz |
Remove 'MPSAFE' annotations from the comments above most system calls: all
system calls now enter without Giant held, and then in some cases, acquire
Giant explicitly.
Remove a number of other MPSAFE annotations in the credential code and
tweak one or two other adjacent comments.
Diffstat (limited to 'sys/security')
-rw-r--r-- | sys/security/audit/audit.c | 5 | ||||
-rw-r--r-- | sys/security/audit/audit_syscalls.c | 12 | ||||
-rw-r--r-- | sys/security/mac/mac_syscalls.c | 30 |
3 files changed, 0 insertions, 47 deletions
diff --git a/sys/security/audit/audit.c b/sys/security/audit/audit.c index 698ca81..44494e8 100644 --- a/sys/security/audit/audit.c +++ b/sys/security/audit/audit.c @@ -290,8 +290,6 @@ currecord(void) } /* - * MPSAFE - * * XXXAUDIT: There are a number of races present in the code below due to * release and re-grab of the mutex. The code should be revised to become * slightly less racy. @@ -333,9 +331,6 @@ audit_free(struct kaudit_record *ar) uma_zfree(audit_record_zone, ar); } -/* - * MPSAFE - */ void audit_commit(struct kaudit_record *ar, int error, int retval) { diff --git a/sys/security/audit/audit_syscalls.c b/sys/security/audit/audit_syscalls.c index 6c12f16..eb62bcf 100644 --- a/sys/security/audit/audit_syscalls.c +++ b/sys/security/audit/audit_syscalls.c @@ -47,8 +47,6 @@ #ifdef AUDIT /* - * MPSAFE - * * System call to allow a user space application to submit a BSM audit record * to the kernel for inclusion in the audit log. This function does little * verification on the audit record that is submitted. @@ -142,8 +140,6 @@ free_out: } /* - * MPSAFE - * * System call to manipulate auditing. */ /* ARGSUSED */ @@ -395,8 +391,6 @@ auditon(struct thread *td, struct auditon_args *uap) } /* - * MPSAFE - * * System calls to manage the user audit information. */ /* ARGSUSED */ @@ -422,7 +416,6 @@ getauid(struct thread *td, struct getauid_args *uap) return copyout(&id, uap->auid, sizeof(id)); } -/* MPSAFE */ /* ARGSUSED */ int setauid(struct thread *td, struct setauid_args *uap) @@ -460,7 +453,6 @@ setauid(struct thread *td, struct setauid_args *uap) } /* - * MPSAFE * System calls to get and set process audit information. */ /* ARGSUSED */ @@ -483,7 +475,6 @@ getaudit(struct thread *td, struct getaudit_args *uap) return (copyout(&ai, uap->auditinfo, sizeof(ai))); } -/* MPSAFE */ /* ARGSUSED */ int setaudit(struct thread *td, struct setaudit_args *uap) @@ -513,7 +504,6 @@ setaudit(struct thread *td, struct setaudit_args *uap) return (0); } -/* MPSAFE */ /* ARGSUSED */ int getaudit_addr(struct thread *td, struct getaudit_addr_args *uap) @@ -528,7 +518,6 @@ getaudit_addr(struct thread *td, struct getaudit_addr_args *uap) return (ENOSYS); } -/* MPSAFE */ /* ARGSUSED */ int setaudit_addr(struct thread *td, struct setaudit_addr_args *uap) @@ -544,7 +533,6 @@ setaudit_addr(struct thread *td, struct setaudit_addr_args *uap) } /* - * MPSAFE * Syscall to manage audit files. */ /* ARGSUSED */ diff --git a/sys/security/mac/mac_syscalls.c b/sys/security/mac/mac_syscalls.c index 3bccf0d..9b5a39d 100644 --- a/sys/security/mac/mac_syscalls.c +++ b/sys/security/mac/mac_syscalls.c @@ -67,9 +67,6 @@ __FBSDID("$FreeBSD$"); #ifdef MAC -/* - * MPSAFE - */ int __mac_get_pid(struct thread *td, struct __mac_get_pid_args *uap) { @@ -119,9 +116,6 @@ __mac_get_pid(struct thread *td, struct __mac_get_pid_args *uap) return (error); } -/* - * MPSAFE - */ int __mac_get_proc(struct thread *td, struct __mac_get_proc_args *uap) { @@ -155,9 +149,6 @@ __mac_get_proc(struct thread *td, struct __mac_get_proc_args *uap) return (error); } -/* - * MPSAFE - */ int __mac_set_proc(struct thread *td, struct __mac_set_proc_args *uap) { @@ -224,9 +215,6 @@ out: return (error); } -/* - * MPSAFE - */ int __mac_get_fd(struct thread *td, struct __mac_get_fd_args *uap) { @@ -313,9 +301,6 @@ out: return (error); } -/* - * MPSAFE - */ int __mac_get_file(struct thread *td, struct __mac_get_file_args *uap) { @@ -366,9 +351,6 @@ out: return (error); } -/* - * MPSAFE - */ int __mac_get_link(struct thread *td, struct __mac_get_link_args *uap) { @@ -419,9 +401,6 @@ out: return (error); } -/* - * MPSAFE - */ int __mac_set_fd(struct thread *td, struct __mac_set_fd_args *uap) { @@ -514,9 +493,6 @@ out: return (error); } -/* - * MPSAFE - */ int __mac_set_file(struct thread *td, struct __mac_set_file_args *uap) { @@ -568,9 +544,6 @@ out: return (error); } -/* - * MPSAFE - */ int __mac_set_link(struct thread *td, struct __mac_set_link_args *uap) { @@ -622,9 +595,6 @@ out: return (error); } -/* - * MPSAFE - */ int mac_syscall(struct thread *td, struct mac_syscall_args *uap) { |