summaryrefslogtreecommitdiffstats
path: root/sys/security
diff options
context:
space:
mode:
authorrwatson <rwatson@FreeBSD.org>2008-05-21 13:05:06 +0000
committerrwatson <rwatson@FreeBSD.org>2008-05-21 13:05:06 +0000
commit375312ef89039b96cf27030ff5c77093806198b7 (patch)
treec1fa160f62128f76919befbd9bf6ffb286ff24fe /sys/security
parent5971791c189c2ddb0bee3aadd934e064d60bf299 (diff)
downloadFreeBSD-src-375312ef89039b96cf27030ff5c77093806198b7.zip
FreeBSD-src-375312ef89039b96cf27030ff5c77093806198b7.tar.gz
Don't use LK_DRAIN before calling VOP_FSYNC() in the panic case for
audit trail failure -- this doesn't contribute anything, and might arguably be wrong. MFC after: 1 week Requested by: attilio
Diffstat (limited to 'sys/security')
-rw-r--r--sys/security/audit/audit_worker.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/security/audit/audit_worker.c b/sys/security/audit/audit_worker.c
index 5c5f2be..96068b5 100644
--- a/sys/security/audit/audit_worker.c
+++ b/sys/security/audit/audit_worker.c
@@ -242,7 +242,7 @@ audit_record_write(struct vnode *vp, struct ucred *cred, void *data,
*/
if (audit_in_failure) {
if (audit_q_len == 0 && audit_pre_q_len == 0) {
- VOP_LOCK(vp, LK_DRAIN | LK_INTERLOCK);
+ VOP_LOCK(vp, LK_EXCLUSIVE | LK_RETRY);
(void)VOP_FSYNC(vp, MNT_WAIT, curthread);
VOP_UNLOCK(vp, 0);
panic("Audit store overflow; record queue drained.");
OpenPOWER on IntegriCloud