diff options
author | rwatson <rwatson@FreeBSD.org> | 2006-06-08 21:58:04 +0000 |
---|---|---|
committer | rwatson <rwatson@FreeBSD.org> | 2006-06-08 21:58:04 +0000 |
commit | 276b52de6741d9113686289307dd193860864262 (patch) | |
tree | 85b12ff72850c02d6263148c27eb78be19f4556d /sys/security/audit | |
parent | f0de47503d95dc350f5fd7efb257f7eb99961bf1 (diff) | |
download | FreeBSD-src-276b52de6741d9113686289307dd193860864262.zip FreeBSD-src-276b52de6741d9113686289307dd193860864262.tar.gz |
Lock process when copying fields from process structure so as to
get a consistent snapshot, as well as get consistent values (i.e.,
that p_comm is properly nul-terminated).
Perforce CID: 98824
Obtained from: TrustedBSD Project
Diffstat (limited to 'sys/security/audit')
-rw-r--r-- | sys/security/audit/audit.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/sys/security/audit/audit.c b/sys/security/audit/audit.c index 7465543..07cf3278 100644 --- a/sys/security/audit/audit.c +++ b/sys/security/audit/audit.c @@ -171,20 +171,19 @@ audit_record_ctor(void *mem, int size, void *arg, int flags) /* * Export the subject credential. - * - * XXXAUDIT: td_ucred access is OK without proc lock, but some other - * fields here may require the proc lock. */ cru2x(td->td_ucred, &ar->k_ar.ar_subj_cred); ar->k_ar.ar_subj_ruid = td->td_ucred->cr_ruid; ar->k_ar.ar_subj_rgid = td->td_ucred->cr_rgid; ar->k_ar.ar_subj_egid = td->td_ucred->cr_groups[0]; + PROC_LOCK(td->td_proc); ar->k_ar.ar_subj_auid = td->td_proc->p_au->ai_auid; ar->k_ar.ar_subj_asid = td->td_proc->p_au->ai_asid; ar->k_ar.ar_subj_pid = td->td_proc->p_pid; ar->k_ar.ar_subj_amask = td->td_proc->p_au->ai_mask; ar->k_ar.ar_subj_term = td->td_proc->p_au->ai_termid; bcopy(td->td_proc->p_comm, ar->k_ar.ar_subj_comm, MAXCOMLEN); + PROC_UNLOCK(td->td_proc); return (0); } |