diff options
| author | rwatson <rwatson@FreeBSD.org> | 2008-06-03 11:06:34 +0000 |
|---|---|---|
| committer | rwatson <rwatson@FreeBSD.org> | 2008-06-03 11:06:34 +0000 |
| commit | 0b6c9d6ea7fe1f60bf282e884fbbb3f3466fe780 (patch) | |
| tree | f97ca54193ed1678b5f503873f6c7030e8655735 /sys/security/audit/audit.c | |
| parent | 5b6fa9215a566de069a91c1c8d9467d7350ac0c2 (diff) | |
| download | FreeBSD-src-0b6c9d6ea7fe1f60bf282e884fbbb3f3466fe780.zip FreeBSD-src-0b6c9d6ea7fe1f60bf282e884fbbb3f3466fe780.tar.gz | |
Add an XXX comment regarding a bug I introduced when modifying the behavior
of audit log vnode rotation: on shutdown, we may not properly drain all
pending records, which could lead to lost records during system shutdown.
Diffstat (limited to 'sys/security/audit/audit.c')
| -rw-r--r-- | sys/security/audit/audit.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/sys/security/audit/audit.c b/sys/security/audit/audit.c index 5f345f7..ede47c9 100644 --- a/sys/security/audit/audit.c +++ b/sys/security/audit/audit.c @@ -269,6 +269,9 @@ SYSINIT(audit_init, SI_SUB_AUDIT, SI_ORDER_FIRST, audit_init, NULL); * Drain the audit queue and close the log at shutdown. Note that this can * be called both from the system shutdown path and also from audit * configuration syscalls, so 'arg' and 'howto' are ignored. + * + * XXXRW: In FreeBSD 7.x and 8.x, this fails to wait for the record queue to + * drain before returning, which could lead to lost records on shutdown. */ void audit_shutdown(void *arg, int howto) |
