diff options
| author | rmacklem <rmacklem@FreeBSD.org> | 2009-06-17 22:50:26 +0000 |
|---|---|---|
| committer | rmacklem <rmacklem@FreeBSD.org> | 2009-06-17 22:50:26 +0000 |
| commit | d88296a89fa7b699f237de7a86e30ce4995a2a4f (patch) | |
| tree | 16d38ade3aac3d505cfcf872a12639bc87a462cc /sys/rpc/svc_generic.c | |
| parent | 8f12a6bcc5ea67ea87483b297472861ac8058429 (diff) | |
| download | FreeBSD-src-d88296a89fa7b699f237de7a86e30ce4995a2a4f.zip FreeBSD-src-d88296a89fa7b699f237de7a86e30ce4995a2a4f.tar.gz | |
Since svc_[dg|vc|tli|tp]_create() did not hold a reference count on the
SVCXPTR structure returned by them, it was possible for the structure
to be free'd before svc_reg() had been completed using the structure.
This patch acquires a reference count on the newly created structure
that is returned by svc_[dg|vc|tli|tp]_create(). It also
adds the appropriate SVC_RELEASE() calls to the callers, except the
experimental nfs subsystem. The latter will be committed separately.
Submitted by: dfr
Tested by: pho
Approved by: kib (mentor)
Diffstat (limited to 'sys/rpc/svc_generic.c')
| -rw-r--r-- | sys/rpc/svc_generic.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sys/rpc/svc_generic.c b/sys/rpc/svc_generic.c index 790b4ba..38380f2 100644 --- a/sys/rpc/svc_generic.c +++ b/sys/rpc/svc_generic.c @@ -120,8 +120,10 @@ svc_create( /* It was not found. Now create a new one */ xprt = svc_tp_create(pool, dispatch, prognum, versnum, NULL, nconf); - if (xprt) + if (xprt) { num++; + SVC_RELEASE(xprt); + } } } __rpc_endconf(handle); @@ -179,6 +181,7 @@ svc_tp_create( (unsigned)prognum, (unsigned)versnum, nconf->nc_netid); xprt_unregister(xprt); + SVC_RELEASE(xprt); return (NULL); } return (xprt); |
