diff options
| author | ps <ps@FreeBSD.org> | 2004-12-06 18:52:28 +0000 |
|---|---|---|
| committer | ps <ps@FreeBSD.org> | 2004-12-06 18:52:28 +0000 |
| commit | aa4aa62af0e8c0c4f728c9ba05822f4f444bae04 (patch) | |
| tree | 5ec68719ae470095ad69494b676752ed2b3bd3a1 /sys/nfsclient/nfsnode.h | |
| parent | f98e4c8a08da099c561a33440e4f624e79c99314 (diff) | |
| download | FreeBSD-src-aa4aa62af0e8c0c4f728c9ba05822f4f444bae04.zip FreeBSD-src-aa4aa62af0e8c0c4f728c9ba05822f4f444bae04.tar.gz | |
Serialize NFS vinvalbuf operations by acquiring/upgrading to the
vnode EXCLUSIVE lock. This prevents threads from adding pages to
the vnode while an invalidation is in progress, closing potential
races. In the bioread() path, callers acquire the SHARED vnode lock
- so while an invalidate was in progress, it was possible to fault
in new pages onto the vnode causing the invalidation to take a while
or fail. We saw these races at Yahoo! with very large files+heavy
concurrent access. Forcing an upgrade to EXCLUSIVE lock before doing
the invalidation closes all these races.
Submitted by: Mohan Srinivasan mohans at yahoo-inc dot com
Diffstat (limited to 'sys/nfsclient/nfsnode.h')
| -rw-r--r-- | sys/nfsclient/nfsnode.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/sys/nfsclient/nfsnode.h b/sys/nfsclient/nfsnode.h index 6e97e71..21bb0d1 100644 --- a/sys/nfsclient/nfsnode.h +++ b/sys/nfsclient/nfsnode.h @@ -139,8 +139,6 @@ struct nfsnode { /* * Flags for n_flag */ -#define NFLUSHWANT 0x0001 /* Want wakeup from a flush in prog. */ -#define NFLUSHINPROG 0x0002 /* Avoid multiple calls to vinvalbuf() */ #define NMODIFIED 0x0004 /* Might have a modified buffer in bio */ #define NWRITEERR 0x0008 /* Flag write errors so close will know */ /* 0x20, 0x40, 0x80 free */ |
