diff options
| author | pjd <pjd@FreeBSD.org> | 2012-06-13 22:12:10 +0000 |
|---|---|---|
| committer | pjd <pjd@FreeBSD.org> | 2012-06-13 22:12:10 +0000 |
| commit | 0ca632f7e9e457afd6f19baf33eb7cb22413134d (patch) | |
| tree | b96b78e408d13c812513bee0b944fc3cdc587057 /sys/netsmb | |
| parent | 786835d5893758148a31887979a8c26809d3a958 (diff) | |
| download | FreeBSD-src-0ca632f7e9e457afd6f19baf33eb7cb22413134d.zip FreeBSD-src-0ca632f7e9e457afd6f19baf33eb7cb22413134d.tar.gz | |
When checking if file descriptor number is valid, explicitely check for 'fd'
being less than 0 instead of using cast-to-unsigned hack.
Today's commit was brought to you by the letters 'B', 'D' and 'E' :)
Diffstat (limited to 'sys/netsmb')
| -rw-r--r-- | sys/netsmb/smb_dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/netsmb/smb_dev.c b/sys/netsmb/smb_dev.c index 6867804..86b2753 100644 --- a/sys/netsmb/smb_dev.c +++ b/sys/netsmb/smb_dev.c @@ -375,7 +375,7 @@ nsmb_getfp(struct filedesc* fdp, int fd, int flag) struct file* fp; FILEDESC_SLOCK(fdp); - if (((u_int)fd) >= fdp->fd_nfiles || + if (fd < 0 || fd >= fdp->fd_nfiles || (fp = fdp->fd_ofiles[fd]) == NULL || (fp->f_flag & flag) == 0) { FILEDESC_SUNLOCK(fdp); |
