diff options
| author | yar <yar@FreeBSD.org> | 2006-06-30 18:25:07 +0000 |
|---|---|---|
| committer | yar <yar@FreeBSD.org> | 2006-06-30 18:25:07 +0000 |
| commit | 563866983d1f41a9d740ebee2c0efdde2f15f9f8 (patch) | |
| tree | 40b40d1a94d3450b7c6dac0bdf7baeab656bb22a /sys/netinet6 | |
| parent | 671ef276e8935d4b41b4d63c05eebf709897f01e (diff) | |
| download | FreeBSD-src-563866983d1f41a9d740ebee2c0efdde2f15f9f8.zip FreeBSD-src-563866983d1f41a9d740ebee2c0efdde2f15f9f8.tar.gz | |
We needn't check "m" for NULL here because "off" should be within
the mbuf chain. If we ever get a buggy caller, a bogus "off" should
be caught by the sanity check at the function entry. Null "m" here
means a very unusual condition of a totally broken mbuf chain (wrong
m_pkthdr.len or whatever), so we can just page fault later.
Found by: Coverity Prevent(tm)
CID: 825
Diffstat (limited to 'sys/netinet6')
| -rw-r--r-- | sys/netinet6/in6_cksum.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/netinet6/in6_cksum.c b/sys/netinet6/in6_cksum.c index b89d5a0..10fb451 100644 --- a/sys/netinet6/in6_cksum.c +++ b/sys/netinet6/in6_cksum.c @@ -153,7 +153,7 @@ in6_cksum(struct mbuf *m, u_int8_t nxt, u_int32_t off, u_int32_t len) /* * Secondly calculate a summary of the first mbuf excluding offset. */ - while (m != NULL && off > 0) { + while (off > 0) { if (m->m_len <= off) off -= m->m_len; else |
