Despite several examples in the kernel, the third argument of

sysctl_handle_int is not sizeof the int type you want to export.
The type must always be an int or an unsigned int.

Remove the instances where a sizeof(variable) is passed to stop
people accidently cut and pasting these examples.

In a few places this was sysctl_handle_int was being used on 64 bit
types, which would truncate the value to be exported.  In these
cases use sysctl_handle_quad to export them and change the format
to Q so that sysctl(1) can still print them.

1 files changed, 1 insertions, 1 deletions

diff --git a/sys/netinet/tcp_timewait.c b/sys/netinet/tcp_timewait.c
index b6279b3..7f4f4fb 100644
--- a/sys/netinet/tcp_timewait.c
+++ b/sys/netinet/tcp_timewait.c
@@ -130,7 +130,7 @@ sysctl_maxtcptw(SYSCTL_HANDLER_ARGS)
 		new = tcptw_auto_size();
 	else
 		new = maxtcptw;
-	error = sysctl_handle_int(oidp, &new, sizeof(int), req);
+	error = sysctl_handle_int(oidp, &new, 0, req);
 	if (error == 0 && req->newptr)
 		if (new >= 32) {
 			maxtcptw = new;