summaryrefslogtreecommitdiffstats
path: root/sys/netinet/tcp_timer.c
diff options
context:
space:
mode:
authorrwatson <rwatson@FreeBSD.org>2006-05-05 06:50:23 +0000
committerrwatson <rwatson@FreeBSD.org>2006-05-05 06:50:23 +0000
commitb1e7cf5430dbc67cf0d6fef98eb6b352bffdeae7 (patch)
treec2036098cfdca6552907a79ebd8deac9e141c8c9 /sys/netinet/tcp_timer.c
parent57924ea487a28a2fe94b9b070afb14ba8c006795 (diff)
downloadFreeBSD-src-b1e7cf5430dbc67cf0d6fef98eb6b352bffdeae7.zip
FreeBSD-src-b1e7cf5430dbc67cf0d6fef98eb6b352bffdeae7.tar.gz
Only return (tw) from tcp_twclose() if reuse is passed, otherwise
return NULL. In principle this shouldn't change the behavior, but avoids returning a potentially invalid/inappropriate pointer to the caller. Found with: Coverity Prevent (tm) Submitted by: pjd MFC after: 3 months
Diffstat (limited to 'sys/netinet/tcp_timer.c')
-rw-r--r--sys/netinet/tcp_timer.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/netinet/tcp_timer.c b/sys/netinet/tcp_timer.c
index db2e618..25cdaec 100644
--- a/sys/netinet/tcp_timer.c
+++ b/sys/netinet/tcp_timer.c
@@ -295,7 +295,7 @@ tcp_timer_2msl_tw(int reuse)
continue;
INP_LOCK(tw->tw_inpcb);
tcp_twclose(tw, reuse);
- return (tw);
+ return (reuse ? tw : NULL);
}
return (NULL);
}
OpenPOWER on IntegriCloud