diff options
author | andre <andre@FreeBSD.org> | 2007-04-20 14:34:54 +0000 |
---|---|---|
committer | andre <andre@FreeBSD.org> | 2007-04-20 14:34:54 +0000 |
commit | edec8cf92bff97762899e3f08bf27d67c2a8a148 (patch) | |
tree | d50ed633523d6e403506f6bc0e65d631b328c6cf /sys/netinet/tcp_syncache.c | |
parent | 707a7006195c6c0989100a57e7cc70ded2ac57ff (diff) | |
download | FreeBSD-src-edec8cf92bff97762899e3f08bf27d67c2a8a148.zip FreeBSD-src-edec8cf92bff97762899e3f08bf27d67c2a8a148.tar.gz |
Remove bogus check for accept queue length and associated failure handling
from the incoming SYN handling section of tcp_input().
Enforcement of the accept queue limits is done by sonewconn() after the
3WHS is completed. It is not necessary to have an earlier check before a
connection request enters the SYN cache awaiting the full handshake. It
rather limits the effectiveness of the syncache by preventing legit and
illegit connections from entering it and having them shaken out before we
hit the real limit which may have vanished by then.
Change return value of syncache_add() to void. No status communication
is required.
Diffstat (limited to 'sys/netinet/tcp_syncache.c')
-rw-r--r-- | sys/netinet/tcp_syncache.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/netinet/tcp_syncache.c b/sys/netinet/tcp_syncache.c index 6d1d1a2..881495a 100644 --- a/sys/netinet/tcp_syncache.c +++ b/sys/netinet/tcp_syncache.c @@ -832,7 +832,7 @@ failed: * consume all available buffer space if it were ACKed. By not ACKing * the data, we avoid this DoS scenario. */ -int +void syncache_add(struct in_conninfo *inc, struct tcpopt *to, struct tcphdr *th, struct inpcb *inp, struct socket **lsop, struct mbuf *m) { @@ -1079,7 +1079,7 @@ done: #endif *lsop = NULL; m_freem(m); - return (1); + return; } static int |