summaryrefslogtreecommitdiffstats
path: root/sys/netinet/tcp_reass.c
diff options
context:
space:
mode:
authordillon <dillon@FreeBSD.org>2002-12-30 19:31:04 +0000
committerdillon <dillon@FreeBSD.org>2002-12-30 19:31:04 +0000
commit35422bf8e1a686e6f1a3fd91026ea8b56b2eabe1 (patch)
treee02dacec56e2f3d597e0c138111a28d0056f7f52 /sys/netinet/tcp_reass.c
parentabab9d20604b7283da859a592db60eb75c6103e5 (diff)
downloadFreeBSD-src-35422bf8e1a686e6f1a3fd91026ea8b56b2eabe1.zip
FreeBSD-src-35422bf8e1a686e6f1a3fd91026ea8b56b2eabe1.tar.gz
Remove the PAWS ack-on-ack debugging printf().
Note that the original RFC 1323 (PAWS) says in 4.2.1 that the out of order / reverse-time-indexed packet should be acknowledged as specified in RFC-793 page 69 then dropped. The original PAWS code in FreeBSD (1994) simply acknowledged the segment unconditionally, which is incorrect, and was fixed in 1.183 (2002). At the moment we do not do checks for SYN or FIN in addition to (tlen != 0), which may or may not be correct, but the worst that ought to happen should be a retry by the sender.
Diffstat (limited to 'sys/netinet/tcp_reass.c')
-rw-r--r--sys/netinet/tcp_reass.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/sys/netinet/tcp_reass.c b/sys/netinet/tcp_reass.c
index b424add..cb52cef 100644
--- a/sys/netinet/tcp_reass.c
+++ b/sys/netinet/tcp_reass.c
@@ -1454,12 +1454,9 @@ trimthenstep6:
tcpstat.tcps_rcvduppack++;
tcpstat.tcps_rcvdupbyte += tlen;
tcpstat.tcps_pawsdrop++;
- if (tlen) {
+ if (tlen)
goto dropafterack;
- } else {
- printf("PAWS ack-on-ack loop avoided\n");
- goto drop;
- }
+ goto drop;
}
}
OpenPOWER on IntegriCloud