diff options
| author | andre <andre@FreeBSD.org> | 2010-08-15 13:25:18 +0000 |
|---|---|---|
| committer | andre <andre@FreeBSD.org> | 2010-08-15 13:25:18 +0000 |
| commit | 915054f299ec27ac3346afa019e48f18f2298d2d (patch) | |
| tree | 52e8f0efc0bdd546be6f2a467082456f5b24489f /sys/netinet/tcp_output.c | |
| parent | 3ddbce13704cd7dae168e7bc7506ac84eb53cfcc (diff) | |
| download | FreeBSD-src-915054f299ec27ac3346afa019e48f18f2298d2d.zip FreeBSD-src-915054f299ec27ac3346afa019e48f18f2298d2d.tar.gz | |
Fix the interaction between 'ICMP fragmentation needed' MTU updates,
path MTU discovery and the tcp_minmss limiter for very small MTU's.
When the MTU suggested by the gateway via ICMP, or if there isn't
any the next smaller step from ip_next_mtu(), is lower than the
floor enforced by net.inet.tcp.minmss (default 216) the value is
ignored and the default MSS (512) is used instead. However the
DF flag in the IP header is still set in tcp_output() preventing
fragmentation by the gateway.
Fix this by using tcp_minmss as the MSS and clear the DF flag if
the suggested MTU is too low. This turns off path MTU dissovery
for the remainder of the session and allows fragmentation to be
done by the gateway.
Only MTU's smaller than 256 are affected. The smallest official
MTU specified is for AX.25 packet radio at 256 octets.
PR: kern/146628
Tested by: Matthew Luckie <mjl-at-luckie org nz>
MFC after: 1 week
Diffstat (limited to 'sys/netinet/tcp_output.c')
| -rw-r--r-- | sys/netinet/tcp_output.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sys/netinet/tcp_output.c b/sys/netinet/tcp_output.c index 4327c7e..be8ea53 100644 --- a/sys/netinet/tcp_output.c +++ b/sys/netinet/tcp_output.c @@ -1186,8 +1186,10 @@ timer: * This might not be the best thing to do according to RFC3390 * Section 2. However the tcp hostcache migitates the problem * so it affects only the first tcp connection with a host. + * + * NB: Don't set DF on small MTU/MSS to have a safe fallback. */ - if (V_path_mtu_discovery) + if (V_path_mtu_discovery && tp->t_maxopd > V_tcp_minmss) ip->ip_off |= IP_DF; error = ip_output(m, tp->t_inpcb->inp_options, NULL, |
