- Found bug in min split point bundling which caused

  incorrect, non-bundlable fragmentation.
- Added min residual to better control split points for
  both how big a msg must be as well as how much needs
  to be left over.
- With our new algo in place, we need to implicitly
  set "end of msg" on the sp-> structure otherwise we
  end up with "hung" associations.
- Room reserved up front in IP header by pushing IP
  header to back of mbuf.
- Fix so FR's peg count of retransmissions needed.
- Fix so an unlucky chunk that never gets across
  will kill the assoc via the kill timer and send an
  abort too.
- Fix bug in sctp_input which can result in a crash.
- Do not strip off IP options anymore.
- Clean up sctp_calculate_rto().
- Get rid of unused sysctl.
- Fixed so we discard all M-Cast
- Fixed so port check done AFTER checksum
- Fixed bug in fragmentation code that prevented
  us from fragmenting a small complete message when
  we needed to.
- Window probes were not marked back to unsent and
  flight adjusted when a sack came in with no
  window change or accepting of the probe data.
  We now fix this with having a mark on the net and
  the chunk so we can clear it out when the sack arrives
  forcing it to retran just like it was "new" this
  improves the handling of window probes, which were
  dropped by the receiver.
- Tighten AUTH protocol error checks during INIT/INIT-ACK exchange

1 files changed, 13 insertions, 11 deletions

diff --git a/sys/netinet/sctp_pcb.h b/sys/netinet/sctp_pcb.h
index 16d03de..34a8452 100644
--- a/sys/netinet/sctp_pcb.h
+++ b/sys/netinet/sctp_pcb.h
@@ -192,7 +192,7 @@ struct sctp_epinfo {
 
 	struct sctpasochead *sctp_restarthash;
 	u_long hashrestartmark;
-	/*
+	/*-
 	 * The TCP model represents a substantial overhead in that we get an
 	 * additional hash table to keep explicit connections in. The
 	 * listening TCP endpoint will exist in the usual ephash above and
@@ -265,7 +265,7 @@ struct sctp_epinfo {
 
 };
 
-/*
+/*-
  * Here we have all the relevant information for each SCTP entity created. We
  * will need to modify this as approprate. We also need to figure out how to
  * access /dev/random.
@@ -337,7 +337,7 @@ struct sctp_pcb {
 #define sctp_lport ip_inp.inp.inp_lport
 
 struct sctp_inpcb {
-	/*
+	/*-
 	 * put an inpcb in front of it all, kind of a waste but we need to
 	 * for compatability with all the other stuff.
 	 */
@@ -383,11 +383,13 @@ struct sctp_inpcb {
 	uint32_t partial_delivery_point;
 	uint32_t sctp_context;
 	struct sctp_sndrcvinfo def_send;
-	/*
-	 * These three are here for the sosend_dgram (pkt, pkt_last and
-	 * control). routine. However, I don't think anyone in the current
-	 * FreeBSD kernel calls this. So they are candidates with sctp_sendm
-	 * for de-supporting.
+	/*-
+	 * These three are here for the sosend_dgram
+	 * (pkt, pkt_last and control).
+	 * routine. However, I don't think anyone in
+	 * the current FreeBSD kernel calls this. So
+	 * they are candidates with sctp_sendm for
+	 * de-supporting.
 	 */
 	struct mbuf *pkt, *pkt_last;
 	struct mbuf *control;
@@ -415,7 +417,7 @@ struct sctp_tcb {
 	struct sctp_block_entry *block_entry;	/* pointer locked by  socket
 						 * send buffer */
 	struct sctp_association asoc;
-	/*
+	/*-
 	 * freed_by_sorcv_sincelast is protected by the sockbuf_lock NOT the
 	 * tcb_lock. Its special in this way to help avoid extra mutex calls
 	 * in the reading of data.
@@ -485,7 +487,7 @@ void
 sctp_move_pcb_and_assoc(struct sctp_inpcb *, struct sctp_inpcb *,
     struct sctp_tcb *);
 
-/*
+/*-
  * For this call ep_addr, the to is the destination endpoint address of the
  * peer (relative to outbound). The from field is only used if the TCP model
  * is enabled and helps distingush amongst the subset bound (non-boundall).
@@ -556,7 +558,7 @@ int sctp_is_vtag_good(struct sctp_inpcb *, uint32_t, struct timeval *);
 
 int sctp_destination_is_reachable(struct sctp_tcb *, struct sockaddr *);
 
-/*
+/*-
  * Null in last arg inpcb indicate run on ALL ep's. Specific inp in last arg
  * indicates run on ONLY assoc's of the specified endpoint.
  */