diff options
| author | tuexen <tuexen@FreeBSD.org> | 2011-09-15 08:49:54 +0000 |
|---|---|---|
| committer | tuexen <tuexen@FreeBSD.org> | 2011-09-15 08:49:54 +0000 |
| commit | 15bb2c985fb8541737d6056f0a21406876105b0b (patch) | |
| tree | 52e8a7176078388d0c66be4bfdd23e13693538d6 /sys/netinet/sctp_pcb.c | |
| parent | f23b1f625d09ffd3a8da3c62c0b6305e9c42119d (diff) | |
| download | FreeBSD-src-15bb2c985fb8541737d6056f0a21406876105b0b.zip FreeBSD-src-15bb2c985fb8541737d6056f0a21406876105b0b.tar.gz | |
Make sure that SCTP rejects broadcast, multicast and wildcard addresses
as remote addresses.
Approved by: re
MFC after: 1 month.
Diffstat (limited to 'sys/netinet/sctp_pcb.c')
| -rw-r--r-- | sys/netinet/sctp_pcb.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/sys/netinet/sctp_pcb.c b/sys/netinet/sctp_pcb.c index e5581e1..b0f2880 100644 --- a/sys/netinet/sctp_pcb.c +++ b/sys/netinet/sctp_pcb.c @@ -4332,7 +4332,10 @@ sctp_aloc_assoc(struct sctp_inpcb *inp, struct sockaddr *firstaddr, struct sockaddr_in *sin; sin = (struct sockaddr_in *)firstaddr; - if ((sin->sin_port == 0) || (sin->sin_addr.s_addr == 0)) { + if ((ntohs(sin->sin_port) == 0) || + (sin->sin_addr.s_addr == INADDR_ANY) || + (sin->sin_addr.s_addr == INADDR_BROADCAST) || + IN_MULTICAST(ntohl(sin->sin_addr.s_addr))) { /* Invalid address */ SCTP_INP_RUNLOCK(inp); SCTP_LTRACE_ERR_RET(inp, NULL, NULL, SCTP_FROM_SCTP_PCB, EINVAL); @@ -4349,8 +4352,9 @@ sctp_aloc_assoc(struct sctp_inpcb *inp, struct sockaddr *firstaddr, struct sockaddr_in6 *sin6; sin6 = (struct sockaddr_in6 *)firstaddr; - if ((sin6->sin6_port == 0) || - (IN6_IS_ADDR_UNSPECIFIED(&sin6->sin6_addr))) { + if ((ntohs(sin6->sin6_port) == 0) || + IN6_IS_ADDR_UNSPECIFIED(&sin6->sin6_addr) || + IN6_IS_ADDR_MULTICAST(&sin6->sin6_addr)) { /* Invalid address */ SCTP_INP_RUNLOCK(inp); SCTP_LTRACE_ERR_RET(inp, NULL, NULL, SCTP_FROM_SCTP_PCB, EINVAL); |
