Plug two bugs introduced with modules conversion:

-UdpAliasIn(): correctly check return code after modules ran.
-alias_nbt: in case of malformed packets (or some other unrecoverable
 error), toss the packet.

1 files changed, 2 insertions, 2 deletions

diff --git a/sys/netinet/libalias/alias.c b/sys/netinet/libalias/alias.c
index c7fc4f4..4a73928 100644
--- a/sys/netinet/libalias/alias.c
+++ b/sys/netinet/libalias/alias.c
@@ -742,7 +742,7 @@ UdpAliasIn(struct libalias *la, struct ip *pip)
 		u_short alias_port;
 		u_short proxy_port;
 		int accumulate;
-		int r = 0, error;
+		int error;
 		struct alias_data ad = {
 			.lnk = lnk, 
 			.oaddr = &original_address, 
@@ -804,7 +804,7 @@ UdpAliasIn(struct libalias *la, struct ip *pip)
 		/*
 		 * If we cannot figure out the packet, ignore it.
 		 */
-		if (r < 0)
+		if (error < 0)
 			return (PKT_ALIAS_IGNORED);
 		else
 			return (PKT_ALIAS_OK);