summaryrefslogtreecommitdiffstats
path: root/sys/netinet/ip_input.c
diff options
context:
space:
mode:
authorrwatson <rwatson@FreeBSD.org>2007-03-25 21:49:50 +0000
committerrwatson <rwatson@FreeBSD.org>2007-03-25 21:49:50 +0000
commit124744263c60bbdc3eff9bae36783d3987835140 (patch)
treed165551c5f147d9b5f5adadc8314432ae22856a2 /sys/netinet/ip_input.c
parent95d0d388ac9c14373708101bce1a8922f43d6386 (diff)
downloadFreeBSD-src-124744263c60bbdc3eff9bae36783d3987835140.zip
FreeBSD-src-124744263c60bbdc3eff9bae36783d3987835140.tar.gz
Replace a comment about RSVP/mrouting with a different but similar comment
explaining that some more locking is needed. The routing pieces are done, but there is an interlocking issue between optionally compiled code and mandatory code. Spotted by: kris
Diffstat (limited to 'sys/netinet/ip_input.c')
-rw-r--r--sys/netinet/ip_input.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/sys/netinet/ip_input.c b/sys/netinet/ip_input.c
index 962b064..4fe44b9 100644
--- a/sys/netinet/ip_input.c
+++ b/sys/netinet/ip_input.c
@@ -1530,11 +1530,10 @@ makedummy:
}
/*
- * XXX these routines are called from the upper part of the kernel.
- * They need to be locked when we remove Giant.
- *
- * They could also be moved to ip_mroute.c, since all the RSVP
- * handling is done there already.
+ * XXXRW: Multicast routing code in ip_mroute.c is generally MPSAFE, but the
+ * ip_rsvp and ip_rsvp_on variables need to be interlocked with rsvp_on
+ * locking. This code remains in ip_input.c as ip_mroute.c is optionally
+ * compiled.
*/
static int ip_rsvp_on;
struct socket *ip_rsvpd;
OpenPOWER on IntegriCloud