Lock ip forwarding route cache. While we're at it, remove the global

variable ipforward_rt by introducing an ip_forward_cacheinval() call
to use to invalidate the cache.

Supported by:	FreeBSD Foundation

1 files changed, 3 insertions, 6 deletions

diff --git a/sys/netinet/in_rmx.c b/sys/netinet/in_rmx.c
index 5092bb9..baa8c71 100644
--- a/sys/netinet/in_rmx.c
+++ b/sys/netinet/in_rmx.c
@@ -141,13 +141,10 @@ in_addroute(void *v_arg, void *n_arg, struct radix_node_head *head,
 
 	/*
 	 * If the new route created successfully, and we are forwarding,
-	 * and there is a cached route, free it.  Otherwise, we may end
-	 * up using the wrong route.
+	 * flush any cached routes to avoid using a stale value.
 	 */
-	if (ret != NULL && ipforwarding && ipforward_rt.ro_rt) {
-		RTFREE(ipforward_rt.ro_rt);
-		ipforward_rt.ro_rt = 0;
-	}
+	if (ret != NULL && ipforwarding)
+		ip_forward_cacheinval();
 
 	return ret;
 }