diff options
| author | andre <andre@FreeBSD.org> | 2003-11-26 20:31:13 +0000 |
|---|---|---|
| committer | andre <andre@FreeBSD.org> | 2003-11-26 20:31:13 +0000 |
| commit | 4a037b3dd4b704250886ced57a0ab6d97411e694 (patch) | |
| tree | ed37fabeb3faa7279dd548d1d6a2325900b034ef /sys/netinet/in_pcb.c | |
| parent | de5ea0895c09169faa73049888b11e02ce9db310 (diff) | |
| download | FreeBSD-src-4a037b3dd4b704250886ced57a0ab6d97411e694.zip FreeBSD-src-4a037b3dd4b704250886ced57a0ab6d97411e694.tar.gz | |
Make sure all uses of stack allocated struct route's are properly
zeroed. Doing a bzero on the entire struct route is not more
expensive than assigning NULL to ro.ro_rt and bzero of ro.ro_dst.
Reviewed by: sam (mentor)
Approved by: re (scottl)
Diffstat (limited to 'sys/netinet/in_pcb.c')
| -rw-r--r-- | sys/netinet/in_pcb.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sys/netinet/in_pcb.c b/sys/netinet/in_pcb.c index 0b9181c..38b7b28 100644 --- a/sys/netinet/in_pcb.c +++ b/sys/netinet/in_pcb.c @@ -581,7 +581,7 @@ in_pcbconnect_setup(inp, nam, laddrp, lportp, faddrp, fportp, oinpp, td) if (laddr.s_addr == INADDR_ANY) { struct route sro; - sro.ro_rt = NULL; + bzero(&sro, sizeof(sro)); ia = (struct in_ifaddr *)0; /* * If route is known our src addr is taken from the i/f, @@ -589,7 +589,6 @@ in_pcbconnect_setup(inp, nam, laddrp, lportp, faddrp, fportp, oinpp, td) */ if ((inp->inp_socket->so_options & SO_DONTROUTE) == 0) { /* Find out route to destination */ - bzero(&sro.ro_dst, sizeof(struct sockaddr_in)); sro.ro_dst.sa_family = AF_INET; sro.ro_dst.sa_len = sizeof(struct sockaddr_in); ((struct sockaddr_in *)&sro.ro_dst)->sin_addr = faddr; |
