diff options
| author | yar <yar@FreeBSD.org> | 2003-12-19 16:03:28 +0000 |
|---|---|---|
| committer | yar <yar@FreeBSD.org> | 2003-12-19 16:03:28 +0000 |
| commit | 127f4e3f65c121e8bb91a1713dbac4a67166016b (patch) | |
| tree | c9ea070b40fd9e2335ed5b7ce0b5cd7fb687c575 /sys/netgraph | |
| parent | 3c75dd4b075493a8936b3afcdf9af74f9467c675 (diff) | |
| download | FreeBSD-src-127f4e3f65c121e8bb91a1713dbac4a67166016b.zip FreeBSD-src-127f4e3f65c121e8bb91a1713dbac4a67166016b.tar.gz | |
The default value of net.graph.nonstandard_pppoe is changed to -1,
which means "always stay in the standard mode of PPPoE operation
regardless of any junk floating around."
As the referenced PR stated clearly, the old default setting of 0
was extremely dangerous because it opened a possibility for a
spurious frame not only to put down a single PPPoE node running
FreeBSD, but to plague *every* FreeBSD node in a PPPoE network in
such a way that those nodes would keep poisoning each other until
rebooted simultaneously.
PR: kern/47920
Reviewed by: Gleb Smirnoff <glebius <at> cell.sick.ru>
MFC after: 1 week
Diffstat (limited to 'sys/netgraph')
| -rw-r--r-- | sys/netgraph/ng_pppoe.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/netgraph/ng_pppoe.c b/sys/netgraph/ng_pppoe.c index 062ab31..fb379b3 100644 --- a/sys/netgraph/ng_pppoe.c +++ b/sys/netgraph/ng_pppoe.c @@ -246,9 +246,9 @@ struct ether_header eh_prototype = ETHERTYPE_PPPOE_DISC}; #define PPPOE_KEEPSTANDARD -1 /* never switch to nonstandard mode */ -#define PPPOE_STANDARD 0 /* try standard mode (default) */ +#define PPPOE_STANDARD 0 /* try standard mode (dangerous!) */ #define PPPOE_NONSTANDARD 1 /* just be in nonstandard mode */ -static int pppoe_mode = PPPOE_STANDARD; +static int pppoe_mode = PPPOE_KEEPSTANDARD; static int ngpppoe_set_ethertype(SYSCTL_HANDLER_ARGS) |
