diff options
author | ed <ed@FreeBSD.org> | 2008-09-26 14:19:52 +0000 |
---|---|---|
committer | ed <ed@FreeBSD.org> | 2008-09-26 14:19:52 +0000 |
commit | 4212d51a7da942b0c717c9965552c9549d90de08 (patch) | |
tree | f45f750affeffb39e162226343b0db9a110c42ce /sys/netgraph | |
parent | 0a873f95fe4b1e8d5d3f6ead357fca828948b3ac (diff) | |
download | FreeBSD-src-4212d51a7da942b0c717c9965552c9549d90de08.zip FreeBSD-src-4212d51a7da942b0c717c9965552c9549d90de08.tar.gz |
Remove unit2minor() use from kernel code.
When I changed kern_conf.c three months ago I made device unit numbers
equal to (unneeded) device minor numbers. We used to require
bitshifting, because there were eight bits in the middle that were
reserved for a device major number. Not very long after I turned
dev2unit(), minor(), unit2minor() and minor2unit() into macro's.
The unit2minor() and minor2unit() macro's were no-ops.
We'd better not remove these four macro's from the kernel, because there
is a lot of (external) code that may still depend on them. For now it's
harmless to remove all invocations of unit2minor() and minor2unit().
Reviewed by: kib
Diffstat (limited to 'sys/netgraph')
-rw-r--r-- | sys/netgraph/ng_device.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/netgraph/ng_device.c b/sys/netgraph/ng_device.c index d8ba676..5db9218 100644 --- a/sys/netgraph/ng_device.c +++ b/sys/netgraph/ng_device.c @@ -179,7 +179,7 @@ ng_device_constructor(node_p node) NG_NODE_SET_PRIVATE(node, priv); priv->node = node; - priv->ngddev = make_dev(&ngd_cdevsw, unit2minor(priv->unit), UID_ROOT, + priv->ngddev = make_dev(&ngd_cdevsw, priv->unit, UID_ROOT, GID_WHEEL, 0600, NG_DEVICE_DEVNAME "%d", priv->unit); if(priv->ngddev == NULL) { printf("%s(): make_dev() failed\n",__func__); |