diff options
| author | mav <mav@FreeBSD.org> | 2008-01-26 22:41:14 +0000 |
|---|---|---|
| committer | mav <mav@FreeBSD.org> | 2008-01-26 22:41:14 +0000 |
| commit | 56891c11ee6e80fa6cf5eb7167832d9a4c0ccff4 (patch) | |
| tree | 0191cfd52a393d65b03c969e288231b23f777b6d /sys/netgraph/ng_ppp.c | |
| parent | 4b87cfa8f895a89a0108387b5ecae05f2bbd87ba (diff) | |
| download | FreeBSD-src-56891c11ee6e80fa6cf5eb7167832d9a4c0ccff4.zip FreeBSD-src-56891c11ee6e80fa6cf5eb7167832d9a4c0ccff4.tar.gz | |
Improve multilink xmit performance by netgraph item reuse.
Diffstat (limited to 'sys/netgraph/ng_ppp.c')
| -rw-r--r-- | sys/netgraph/ng_ppp.c | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/sys/netgraph/ng_ppp.c b/sys/netgraph/ng_ppp.c index 86fa186..553f23b 100644 --- a/sys/netgraph/ng_ppp.c +++ b/sys/netgraph/ng_ppp.c @@ -1974,11 +1974,12 @@ ng_ppp_mp_xmit(node_p node, item_p item, uint16_t proto) /* Extract mbuf. */ NGI_GET_M(item, m); - NG_FREE_ITEM(item); /* Prepend protocol number, possibly compressed. */ - if ((m = ng_ppp_addproto(m, proto, 1)) == NULL) + if ((m = ng_ppp_addproto(m, proto, 1)) == NULL) { + NG_FREE_ITEM(item); return (ENOBUFS); + } /* Clear distribution plan */ bzero(&distrib, priv->numActiveLinks * sizeof(distrib[0])); @@ -2067,6 +2068,8 @@ deliver: if (n == NULL) { NG_FREE_M(m); + if (firstFragment) + NG_FREE_ITEM(item); return (ENOMEM); } m_tag_copy_chain(n, m, M_DONTWAIT); @@ -2100,11 +2103,18 @@ deliver: if (m2 == NULL) { if (!lastFragment) m_freem(m); + if (firstFragment) + NG_FREE_ITEM(item); return (ENOBUFS); } /* Send fragment */ - if ((item = ng_package_data(m2, NG_NOFLAGS)) != NULL) { + if (firstFragment) { + NGI_M(item) = m2; /* Reuse original item. */ + } else { + item = ng_package_data(m2, NG_NOFLAGS); + } + if (item != NULL) { error = ng_ppp_link_xmit(node, item, PROT_MP, linkNum, (firstFragment?plen:0)); if (error != 0) { |
