Fix line discipline switching issues: If opening a new ldisc fails,

we have to revert to TTYDISC which we know will successfully open
rather than try the previous ldisc which might also fail to open.

Do not let ldisc implementations muck about with ->t_line, and remove
code which checks for reopens, it should never happen.

Move ldisc->l_hotchar to tty->t_hotchar and have ldisc implementation
initialize it in their open routines.  Reset to zero when we enter
TTYDISC.  ("no" should really be -1 since zero could be a valid
hotchar for certain old european mainframe protocols.)

1 files changed, 1 insertions, 10 deletions

diff --git a/sys/netgraph/bluetooth/drivers/h4/ng_h4.c b/sys/netgraph/bluetooth/drivers/h4/ng_h4.c
index 27b6641..1710a4c 100644
--- a/sys/netgraph/bluetooth/drivers/h4/ng_h4.c
+++ b/sys/netgraph/bluetooth/drivers/h4/ng_h4.c
@@ -97,8 +97,7 @@ static struct linesw		ng_h4_disc = {
 	ng_h4_ioctl,		/* ioctl */
 	ng_h4_input,		/* input */
 	ng_h4_start,		/* start */
-	ttymodem,		/* modem */
-	0 			/* hotchar (don't really care which one) */
+	ttymodem		/* modem */
 };
 
 /* Netgraph methods */
@@ -161,13 +160,6 @@ ng_h4_open(struct cdev *dev, struct tty *tp)
 	s = splnet(); /* XXX */
 	spltty(); /* XXX */
 
-	/* Already installed? */
-	if (tp->t_line == H4DISC) {
-		sc = (ng_h4_info_p) tp->t_sc;
-		if (sc != NULL && sc->tp == tp)
-			goto out;
-	}
-
 	/* Initialize private struct */
 	MALLOC(sc, ng_h4_info_p, sizeof(*sc), M_NETGRAPH_H4, M_NOWAIT|M_ZERO);
 	if (sc == NULL) {
@@ -243,7 +235,6 @@ ng_h4_close(struct tty *tp, int flag)
 
 	ttyflush(tp, FREAD | FWRITE);
 	clist_free_cblocks(&tp->t_outq);
-	tp->t_line = 0;
 	if (sc != NULL) {
 		tp->t_sc = NULL;