Reduce network stack oddness: implement .pru_sockaddr and .pru_peeraddr

protocol entry points using functions named proto_getsockaddr and
proto_getpeeraddr rather than proto_setsockaddr and proto_setpeeraddr.
While it's true that sockaddrs are allocated and set, the net effect is
to retrieve (get) the socket address or peer address from a socket, not
set it, so align names to that intent.

1 files changed, 5 insertions, 5 deletions

diff --git a/sys/netatalk/ddp_usrreq.c b/sys/netatalk/ddp_usrreq.c
index d2af633..df38e2a 100644
--- a/sys/netatalk/ddp_usrreq.c
+++ b/sys/netatalk/ddp_usrreq.c
@@ -285,19 +285,19 @@ ddp_clean(void)
 #endif
 
 static int
-at_setpeeraddr(struct socket *so, struct sockaddr **nam)
+at_getpeeraddr(struct socket *so, struct sockaddr **nam)
 {
 
 	return (EOPNOTSUPP);
 }
 
 static int
-at_setsockaddr(struct socket *so, struct sockaddr **nam)
+at_getsockaddr(struct socket *so, struct sockaddr **nam)
 {
 	struct ddpcb	*ddp;
 
 	ddp = sotoddpcb(so);
-	KASSERT(ddp != NULL, ("at_setsockaddr: ddp == NULL"));
+	KASSERT(ddp != NULL, ("at_getsockaddr: ddp == NULL"));
 
 	DDP_LOCK(ddp);
 	at_sockaddr(ddp, nam);
@@ -313,9 +313,9 @@ struct pr_usrreqs ddp_usrreqs = {
 	.pru_control =		at_control,
 	.pru_detach =		ddp_detach,
 	.pru_disconnect =	ddp_disconnect,
-	.pru_peeraddr =		at_setpeeraddr,
+	.pru_peeraddr =		at_getpeeraddr,
 	.pru_send =		ddp_send,
 	.pru_shutdown =		ddp_shutdown,
-	.pru_sockaddr =		at_setsockaddr,
+	.pru_sockaddr =		at_getsockaddr,
 	.pru_close =		ddp_close,
 };