Do a pass over all modules in the kernel and make them return EOPNOTSUPP

for unknown events.

A number of modules return EINVAL in this instance, and I have left
those alone for now and instead taught MOD_QUIESCE to accept this
as "didn't do anything".

12 files changed, 22 insertions, 3 deletions

diff --git a/sys/net/if_disc.c b/sys/net/if_disc.c
index 6132da9..1b71630 100644
--- a/sys/net/if_disc.c
+++ b/sys/net/if_disc.c
@@ -155,6 +155,8 @@ disc_modevent(module_t mod, int type, void *data)
 		mtx_unlock(&disc_mtx);
 		mtx_destroy(&disc_mtx);
 		break;
+	default:
+		return (EOPNOTSUPP);
 	}
 	return (0);
 }
diff --git a/sys/net/if_ef.c b/sys/net/if_ef.c
index 23741d1..616be9f 100644
--- a/sys/net/if_ef.c
+++ b/sys/net/if_ef.c
@@ -584,7 +584,7 @@ if_ef_modevent(module_t mod, int type, void *data)
 	    case MOD_UNLOAD:
 		return ef_unload();
 	    default:
-		break;
+		return EOPNOTSUPP;
 	}
 	return 0;
 }
diff --git a/sys/net/if_faith.c b/sys/net/if_faith.c
index c8da1cd..91b727c 100644
--- a/sys/net/if_faith.c
+++ b/sys/net/if_faith.c
@@ -145,6 +145,8 @@ faithmodevent(mod, type, data)
 		mtx_unlock(&faith_mtx);
 		mtx_destroy(&faith_mtx);
 		break;
+	default:
+		return EOPNOTSUPP;
 	}
 	return 0;
 }
diff --git a/sys/net/if_gif.c b/sys/net/if_gif.c
index 84ba528..6d2221c 100644
--- a/sys/net/if_gif.c
+++ b/sys/net/if_gif.c
@@ -255,6 +255,8 @@ gifmodevent(mod, type, data)
 		ip6_gif_hlim = 0;
 #endif
 		break;
+	default:
+		return EOPNOTSUPP;
 	}
 	return 0;
 }
diff --git a/sys/net/if_gre.c b/sys/net/if_gre.c
index a5dcc7d..c0feec0 100644
--- a/sys/net/if_gre.c
+++ b/sys/net/if_gre.c
@@ -767,6 +767,8 @@ gremodevent(module_t mod, int type, void *data)
 		mtx_unlock(&gre_mtx);
 		mtx_destroy(&gre_mtx);
 		break;
+	default:
+		return EOPNOTSUPP;
 	}
 	return 0;
 }
diff --git a/sys/net/if_loop.c b/sys/net/if_loop.c
index 97af1d3..8c4c5da 100644
--- a/sys/net/if_loop.c
+++ b/sys/net/if_loop.c
@@ -172,6 +172,8 @@ loop_modevent(module_t mod, int type, void *data)
 	case MOD_UNLOAD: 
 		printf("loop module unload - not possible for this module type\n"); 
 		return EINVAL; 
+	default:
+		return EOPNOTSUPP;
 	} 
 	return 0; 
 } 
diff --git a/sys/net/if_ppp.c b/sys/net/if_ppp.c
index 2e808da..8f06594 100644
--- a/sys/net/if_ppp.c
+++ b/sys/net/if_ppp.c
@@ -294,6 +294,8 @@ ppp_modevent(module_t mod, int type, void *data)
 		}
 		PPP_LIST_LOCK_DESTROY();
 		break; 
+	default:
+		return EOPNOTSUPP;
 	} 
 	return 0; 
 } 
diff --git a/sys/net/if_sl.c b/sys/net/if_sl.c
index 220e9ec..6d2b996 100644
--- a/sys/net/if_sl.c
+++ b/sys/net/if_sl.c
@@ -210,6 +210,8 @@ sl_modevent(module_t mod, int type, void *data)
 		ldisc_deregister(SLIPDISC);
 		printf("if_sl module unload - not possible for this module type\n"); 
 		return EINVAL; 
+	default:
+		return EOPNOTSUPP;
 	} 
 	return 0; 
 } 
diff --git a/sys/net/if_spppsubr.c b/sys/net/if_spppsubr.c
index bfc01f0..4c9f304 100644
--- a/sys/net/if_spppsubr.c
+++ b/sys/net/if_spppsubr.c
@@ -484,9 +484,8 @@ sppp_modevent(module_t mod, int type, void *unused)
 		break;
 	case MOD_UNLOAD:
 		return EACCES;
-		break;
 	default:
-		break;
+		return EOPNOTSUPP;
 	}
 	return 0;
 }
diff --git a/sys/net/if_stf.c b/sys/net/if_stf.c
index 2f9eb02..eff2c7e 100644
--- a/sys/net/if_stf.c
+++ b/sys/net/if_stf.c
@@ -301,6 +301,8 @@ stfmodevent(mod, type, data)
 		mtx_unlock(&stf_mtx);
 		mtx_destroy(&stf_mtx);
 		break;
+	default:
+		return (EOPNOTSUPP);
 	}
 
 	return (0);
diff --git a/sys/net/if_tun.c b/sys/net/if_tun.c
index 23cb20b..065f6c9 100644
--- a/sys/net/if_tun.c
+++ b/sys/net/if_tun.c
@@ -204,6 +204,8 @@ tunmodevent(module_t mod, int type, void *data)
 		clone_cleanup(&tunclones);
 		mtx_destroy(&tunmtx);
 		break;
+	default:
+		return EOPNOTSUPP;
 	}
 	return 0;
 }
diff --git a/sys/net/if_vlan.c b/sys/net/if_vlan.c
index da9b280..4f6e0bd 100644
--- a/sys/net/if_vlan.c
+++ b/sys/net/if_vlan.c
@@ -248,6 +248,8 @@ vlan_modevent(module_t mod, int type, void *data)
 			    &LIST_FIRST(&ifv_list)->ifv_if);
 		VLAN_LOCK_DESTROY();
 		break;
+	default:
+		return (EOPNOTSUPP);
 	}
 	return (0);
 }