diff options
| author | glebius <glebius@FreeBSD.org> | 2010-07-27 10:05:27 +0000 |
|---|---|---|
| committer | glebius <glebius@FreeBSD.org> | 2010-07-27 10:05:27 +0000 |
| commit | 43f917d899536fa8b0f464c85a9282b6150eda9a (patch) | |
| tree | b1b0f1ea57d9c27281a15b320aefbc6a9cfcd9c8 /sys/net | |
| parent | 14fecff4af267e329c5b6b92b3832986bf141250 (diff) | |
| download | FreeBSD-src-43f917d899536fa8b0f464c85a9282b6150eda9a.zip FreeBSD-src-43f917d899536fa8b0f464c85a9282b6150eda9a.tar.gz | |
When installing a new ARP entry via 'arp -S', lla_lookup() will
either find an existing entry, or allocate a new one. In the latter
case an entry would have flags, that were supplied as argument to
lla_lookup(). In case of an existing entry, flags aren't modified.
This lead to losing LLE_PUB and/or LLE_PROXY flags.
We should apply these flags either in lla_rt_output() or in the
in.c:in_lltable_lookup(). It seems to me that lla_rt_output() is
a more correct choice.
PR: kern/148784, kern/146539
Silence from: qingli, 5 days
Diffstat (limited to 'sys/net')
| -rw-r--r-- | sys/net/if_llatbl.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sys/net/if_llatbl.c b/sys/net/if_llatbl.c index 8e193c1..3af9eff 100644 --- a/sys/net/if_llatbl.c +++ b/sys/net/if_llatbl.c @@ -337,6 +337,7 @@ lla_rt_output(struct rt_msghdr *rtm, struct rt_addrinfo *info) * LLE_DELETED flag, and reset the expiration timer */ bcopy(LLADDR(dl), &lle->ll_addr, ifp->if_addrlen); + lle->la_flags |= (flags & (LLE_PUB | LLE_PROXY)); lle->la_flags |= LLE_VALID; lle->la_flags &= ~LLE_DELETED; #ifdef INET6 |
