diff options
| author | brooks <brooks@FreeBSD.org> | 2008-04-19 22:04:51 +0000 |
|---|---|---|
| committer | brooks <brooks@FreeBSD.org> | 2008-04-19 22:04:51 +0000 |
| commit | bf4b91bf6ad2d2958ae7597f7428fcb04f8ef393 (patch) | |
| tree | b67ece9c74076830861eede172d7ab8375354a7a /sys/net/if.c | |
| parent | c7094ab9ab7051337a2de22c0e040b81156fc7e3 (diff) | |
| download | FreeBSD-src-bf4b91bf6ad2d2958ae7597f7428fcb04f8ef393.zip FreeBSD-src-bf4b91bf6ad2d2958ae7597f7428fcb04f8ef393.tar.gz | |
Delay the global registration of the struct ifnet in if_alloc() until after
we're certain the allocation will entierly succeed. This fixes a leak in a
fairly unlikely case.
Reported by: vijay singh <vijjus at rocketmail dot com>
MFC after: 1 week
Diffstat (limited to 'sys/net/if.c')
| -rw-r--r-- | sys/net/if.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/net/if.c b/sys/net/if.c index 8929c19..c3c367b 100644 --- a/sys/net/if.c +++ b/sys/net/if.c @@ -377,7 +377,6 @@ if_alloc(u_char type) if_index = ifp->if_index; if (if_index >= if_indexlim) if_grow(); - ifnet_byindex(ifp->if_index) = ifp; ifp->if_type = type; @@ -388,6 +387,7 @@ if_alloc(u_char type) return (NULL); } } + ifnet_byindex(ifp->if_index) = ifp; IF_ADDR_LOCK_INIT(ifp); return (ifp); |
