diff options
| author | sam <sam@FreeBSD.org> | 2003-02-11 21:48:20 +0000 |
|---|---|---|
| committer | sam <sam@FreeBSD.org> | 2003-02-11 21:48:20 +0000 |
| commit | b65dfed25b7d235dd26e37e6b7cf060f70360438 (patch) | |
| tree | 0dd2e7f3d66dd92fb26738b8ad20c7d8397f8d3e /sys/net/bridge.c | |
| parent | bebc78d3e1199cbab99577edd2dc9b60f22a917e (diff) | |
| download | FreeBSD-src-b65dfed25b7d235dd26e37e6b7cf060f70360438.zip FreeBSD-src-b65dfed25b7d235dd26e37e6b7cf060f70360438.tar.gz | |
PFIL_HOOKS optimization: check if at least one hook is present before
munging the IP header to pass to the hooks
Diffstat (limited to 'sys/net/bridge.c')
| -rw-r--r-- | sys/net/bridge.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sys/net/bridge.c b/sys/net/bridge.c index fef1b98..2684bad 100644 --- a/sys/net/bridge.c +++ b/sys/net/bridge.c @@ -904,7 +904,7 @@ bdg_forward(struct mbuf *m0, struct ifnet *dst) * NetBSD-style generic packet filter, pfil(9), hooks. * Enables ipf(8) in bridging. */ - if (m0->m_pkthdr.len >= sizeof(struct ip) && + if (pfh != NULL && m0->m_pkthdr.len >= sizeof(struct ip) && ntohs(save_eh.ether_type) == ETHERTYPE_IP) { /* * before calling the firewall, swap fields the same as IP does. @@ -915,7 +915,7 @@ bdg_forward(struct mbuf *m0, struct ifnet *dst) ip->ip_len = ntohs(ip->ip_len); ip->ip_off = ntohs(ip->ip_off); - for (; pfh; pfh = TAILQ_NEXT(pfh, pfil_link)) + do { if (pfh->pfil_func) { rv = pfh->pfil_func(ip, ip->ip_hl << 2, src, 0, &m0); if (m0 == NULL) { @@ -928,6 +928,7 @@ bdg_forward(struct mbuf *m0, struct ifnet *dst) } ip = mtod(m0, struct ip *); } + } while (pfh = TAILQ_NEXT(pfh, pfil_link)); /* * If we get here, the firewall has passed the pkt, but the mbuf * pointer might have changed. Restore ip and the fields ntohs()'d. |
