This is the roumored ATA modulerisation works, and it needs a little explanation.

If you just config KERNEL as usual there should be no apparent changes, you'll get all chipset support code compiled in.

However there is now a way to only compile in code for chipsets needed on a pr vendor basis. ATA now has the following "device" entries:

atacore:	ATA core functionality, always needed for any ATA setup

atacard:	CARDBUS support
atacbus:	PC98 cbus support
ataisa:		ISA bus support
atapci:		PCI bus support only generic chipset support.

ataahci:	AHCI support, also pulled in by some vendor modules.

ataacard, ataacerlabs, ataadaptec, ataamd, ataati, atacenatek, atacypress, atacyrix, atahighpoint, ataintel, ataite, atajmicron, atamarvell, atamicron, atanational, atanetcell, atanvidia, atapromise, ataserverworks, atasiliconimage, atasis, atavia;	Vendor support, ie atavia for VIA chipsets

atadisk:	ATA disk driver
ataraid:	ATA softraid driver

atapicd:	ATAPI cd/dvd driver
atapifd:	ATAPI floppy/flashdisk driver
atapist:	ATAPI tape driver

atausb:		ATA<>USB bridge
atapicam:	ATA<>CAM bridge

This makes it possible to config a kernel with just VIA chipset support by having the following ATA lines in the kernel config file:

device          atacore
device          atapci
device          atavia

And then you need the atadisk, atapicd etc lines in there just as usual.

If you use ATA as modules loaded at boot there is few changes except the rename of the "ata" module to "atacore", things looks just as usual.
However under atapci you now have a whole bunch of vendor specific drivers, that you can kldload individually depending on you needs. Drivers have the same names as used in the kernel config explained above.

31 files changed, 382 insertions, 4 deletions

diff --git a/sys/modules/ata/Makefile b/sys/modules/ata/Makefile
index c67ade9..0e79b1e 100644
--- a/sys/modules/ata/Makefile
+++ b/sys/modules/ata/Makefile
@@ -1,6 +1,6 @@
 # $FreeBSD$
 
-SUBDIR = ata
+SUBDIR = atacore
 SUBDIR += atacard
 .if ${MACHINE} == "pc98"
 SUBDIR += atacbus
diff --git a/sys/modules/ata/ata/Makefile b/sys/modules/ata/atacore/Makefile
index 262984e..7b8d9e2 100644
--- a/sys/modules/ata/ata/Makefile
+++ b/sys/modules/ata/atacore/Makefile
@@ -3,8 +3,7 @@
 .PATH: ${.CURDIR}/../../../dev/ata
 
 KMOD=	ata
-SRCS=	ata-all.c ata-queue.c ata-lowlevel.c ata_if.c
-#	ata-pci.c ata-dma.c ata-chipset.c
+SRCS=	ata-all.c ata-lowlevel.c ata-queue.c ata_if.c
 SRCS+=	opt_ata.h ata_if.h device_if.h bus_if.h
 
 .include <bsd.kmod.mk>
diff --git a/sys/modules/ata/atadevel/Makefile b/sys/modules/ata/atadevel/Makefile
new file mode 100644
index 0000000..d87c84f
--- /dev/null
+++ b/sys/modules/ata/atadevel/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../dev/ata
+
+KMOD=	atadevel
+SRCS=	ata-devel.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+CFLAGS+=-g
+
+.include <bsd.kmod.mk>
diff --git a/sys/modules/ata/atadevel/ata-devel.c b/sys/modules/ata/atadevel/ata-devel.c
new file mode 100644
index 0000000..dbbbab2
--- /dev/null
+++ b/sys/modules/ata/atadevel/ata-devel.c
@@ -0,0 +1,125 @@
+/*-
+ * Copyright (c) 2008 S\xf8ren Schmidt <sos@FreeBSD.org>
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer,
+ *    without modification, immediately at the beginning of the file.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
+ * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+ * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+ * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <sys/cdefs.h>
+__FBSDID("$FreeBSD$");
+
+#include <sys/param.h>
+#include <sys/module.h>
+#include <sys/systm.h>
+#include <sys/kernel.h>
+#include <sys/ata.h>
+#include <sys/lock.h>
+#include <sys/mutex.h>
+#include <sys/sema.h>
+#include <sys/taskqueue.h>
+#include <sys/errno.h>
+#include <sys/kernel.h>
+#include <sys/conf.h>
+#include <sys/uio.h>
+#include <sys/malloc.h>
+#include <sys/bus.h>
+
+#include <vm/uma.h>
+
+#include <machine/stdarg.h>
+#include <machine/resource.h>
+#include <machine/bus.h>
+#include <sys/rman.h>
+
+#include <dev/pci/pcivar.h> 
+#include <dev/pci/pcireg.h>
+
+#include <dev/ata/ata-all.h>
+#include <dev/ata/ata-pci.h>
+#include <ata_if.h>
+
+/* prototypes */
+static int ata_devel_chipinit(device_t dev);
+static int ata_devel_allocate(device_t dev);
+static void ata_devel_setmode(device_t dev, int mode);
+
+
+static int
+ata_devel_probe(device_t dev)
+{
+    struct ata_pci_controller *ctlr = device_get_softc(dev);
+
+    device_printf(dev, "ata_devel_probe(): PCIID=0x%08x\n", pci_get_devid(dev));
+    if (pci_get_devid(dev) == 0x12345678) {
+        printf("test probe successful!\n");
+	device_set_desc(dev, "ATA DEVEL controller");
+	ctlr->chipinit = ata_devel_chipinit;
+	return 0;
+    }
+    return ENXIO;
+}
+
+static int
+ata_devel_chipinit(device_t dev)
+{
+    struct ata_pci_controller *ctlr = device_get_softc(dev);
+
+    /* setup interrupt delivery */
+    if (ata_setup_interrupt(dev, ata_generic_intr))
+	return ENXIO;
+
+    /* perform any chipset specific setups here */
+
+    /* setup function ptr's, in this case allocate and setmode */
+    ctlr->allocate = ata_devel_allocate;
+    ctlr->setmode = ata_devel_setmode;
+
+    return 0;
+}
+
+static int
+ata_devel_allocate(device_t dev)
+{
+    if (ata_pci_allocate(dev))
+	return ENXIO;
+
+    /* setup channel specifics here like offsets to registers etc */
+
+    return 0;
+}
+
+static void
+ata_devel_setmode(device_t dev, int mode)
+{
+    struct ata_device *atadev = device_get_softc(dev);
+    int error;
+
+    error = ata_controlcmd(dev, ATA_SETFEATURES, ATA_SF_SETXFER, 0,
+			   ata_limit_mode(dev, mode, ATA_UDMA5));
+    if (bootverbose)
+	device_printf(dev, "%ssetting %s on DEVEL chip\n",
+		      (error) ? "FAILURE " : "", ata_mode2str(mode));
+    if (!error)
+	atadev->mode = mode;
+}
+
+ATA_DECLARE_DRIVER(ata_devel);
diff --git a/sys/modules/ata/atapci/Makefile b/sys/modules/ata/atapci/Makefile
index 00d188b..6ce854e 100644
--- a/sys/modules/ata/atapci/Makefile
+++ b/sys/modules/ata/atapci/Makefile
@@ -1,9 +1,12 @@
 # $FreeBSD$
 
+SUBDIR += chipsets
+
 .PATH: ${.CURDIR}/../../../dev/ata
 
 KMOD=	atapci
-SRCS=	ata-pci.c ata-dma.c ata-chipset.c
+SRCS=	ata-pci.c ata-dma.c ata-sata.c
 SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
 
 .include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/Makefile.inc b/sys/modules/ata/atapci/Makefile.inc
new file mode 100644
index 0000000..265f86d
--- /dev/null
+++ b/sys/modules/ata/atapci/Makefile.inc
@@ -0,0 +1,3 @@
+# $FreeBSD$
+
+.include "../Makefile.inc"
diff --git a/sys/modules/ata/atapci/chipsets/Makefile b/sys/modules/ata/atapci/chipsets/Makefile
new file mode 100644
index 0000000..5468359
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/Makefile
@@ -0,0 +1,5 @@
+# $FreeBSD$
+
+SUBDIR += ataacard ataacerlabs ataadaptec ataahci ataamd ataati atacenatek atacypress atacyrix atahighpoint ataintel ataite atajmicron atamarvell atamicron atanational atanetcell atanvidia atapromise ataserverworks atasiliconimage atasis atavia
+
+.include <bsd.subdir.mk>
diff --git a/sys/modules/ata/atapci/chipsets/Makefile.inc b/sys/modules/ata/atapci/chipsets/Makefile.inc
new file mode 100644
index 0000000..265f86d
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/Makefile.inc
@@ -0,0 +1,3 @@
+# $FreeBSD$
+
+.include "../Makefile.inc"
diff --git a/sys/modules/ata/atapci/chipsets/ataacard/Makefile b/sys/modules/ata/atapci/chipsets/ataacard/Makefile
new file mode 100644
index 0000000..28da0f2
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/ataacard/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	ataacard
+SRCS=	ata-acard.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/ataacerlabs/Makefile b/sys/modules/ata/atapci/chipsets/ataacerlabs/Makefile
new file mode 100644
index 0000000..8c36db1
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/ataacerlabs/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	ataacerlabs
+SRCS=	ata-acerlabs.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/ataadaptec/Makefile b/sys/modules/ata/atapci/chipsets/ataadaptec/Makefile
new file mode 100644
index 0000000..a6e22b9
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/ataadaptec/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	ataadaptec
+SRCS=	ata-adaptec.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/ataahci/Makefile b/sys/modules/ata/atapci/chipsets/ataahci/Makefile
new file mode 100644
index 0000000..c21bf19
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/ataahci/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	ataahci
+SRCS=	ata-ahci.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/ataamd/Makefile b/sys/modules/ata/atapci/chipsets/ataamd/Makefile
new file mode 100644
index 0000000..f1c6c02
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/ataamd/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	ataamd
+SRCS=	ata-amd.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/ataati/Makefile b/sys/modules/ata/atapci/chipsets/ataati/Makefile
new file mode 100644
index 0000000..5c96e5c
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/ataati/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	ataati
+SRCS=	ata-ati.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atacenatek/Makefile b/sys/modules/ata/atapci/chipsets/atacenatek/Makefile
new file mode 100644
index 0000000..90eae7a
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atacenatek/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atacenatek
+SRCS=	ata-cenatek.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atacypress/Makefile b/sys/modules/ata/atapci/chipsets/atacypress/Makefile
new file mode 100644
index 0000000..e356ea0
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atacypress/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atacypress
+SRCS=	ata-cypress.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atacyrix/Makefile b/sys/modules/ata/atapci/chipsets/atacyrix/Makefile
new file mode 100644
index 0000000..405e8cf
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atacyrix/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atacyrix
+SRCS=	ata-cyrix.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atahighpoint/Makefile b/sys/modules/ata/atapci/chipsets/atahighpoint/Makefile
new file mode 100644
index 0000000..728829c
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atahighpoint/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atahighpoint
+SRCS=	ata-highpoint.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/ataintel/Makefile b/sys/modules/ata/atapci/chipsets/ataintel/Makefile
new file mode 100644
index 0000000..676ad74
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/ataintel/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	ataintel
+SRCS=	ata-intel.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/ataite/Makefile b/sys/modules/ata/atapci/chipsets/ataite/Makefile
new file mode 100644
index 0000000..f93eea4
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/ataite/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	ataite
+SRCS=	ata-ite.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atajmicron/Makefile b/sys/modules/ata/atapci/chipsets/atajmicron/Makefile
new file mode 100644
index 0000000..94b6178
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atajmicron/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atajmicron
+SRCS=	ata-jmicron.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atamarvell/Makefile b/sys/modules/ata/atapci/chipsets/atamarvell/Makefile
new file mode 100644
index 0000000..c828313
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atamarvell/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atamarvell
+SRCS=	ata-marvell.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atamicron/Makefile b/sys/modules/ata/atapci/chipsets/atamicron/Makefile
new file mode 100644
index 0000000..b002a0b
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atamicron/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atamicron
+SRCS=	ata-micron.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atanational/Makefile b/sys/modules/ata/atapci/chipsets/atanational/Makefile
new file mode 100644
index 0000000..52cae4c
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atanational/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atanational
+SRCS=	ata-national.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atanetcell/Makefile b/sys/modules/ata/atapci/chipsets/atanetcell/Makefile
new file mode 100644
index 0000000..dae87a0
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atanetcell/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atanetcell
+SRCS=	ata-netcell.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atanvidia/Makefile b/sys/modules/ata/atapci/chipsets/atanvidia/Makefile
new file mode 100644
index 0000000..452bf22
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atanvidia/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atanvidia
+SRCS=	ata-nvidia.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atapromise/Makefile b/sys/modules/ata/atapci/chipsets/atapromise/Makefile
new file mode 100644
index 0000000..70d46e1
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atapromise/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atapromise
+SRCS=	ata-promise.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/ataserverworks/Makefile b/sys/modules/ata/atapci/chipsets/ataserverworks/Makefile
new file mode 100644
index 0000000..2b789a5
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/ataserverworks/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	ataserverworks
+SRCS=	ata-serverworks.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atasiliconimage/Makefile b/sys/modules/ata/atapci/chipsets/atasiliconimage/Makefile
new file mode 100644
index 0000000..ea7aca3
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atasiliconimage/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atasiliconimage
+SRCS=	ata-siliconimage.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atasis/Makefile b/sys/modules/ata/atapci/chipsets/atasis/Makefile
new file mode 100644
index 0000000..b601452
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atasis/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atasis
+SRCS=	ata-sis.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+
diff --git a/sys/modules/ata/atapci/chipsets/atavia/Makefile b/sys/modules/ata/atapci/chipsets/atavia/Makefile
new file mode 100644
index 0000000..75e66b0
--- /dev/null
+++ b/sys/modules/ata/atapci/chipsets/atavia/Makefile
@@ -0,0 +1,10 @@
+# $FreeBSD$
+
+.PATH: ${.CURDIR}/../../../../../dev/ata/chipsets
+
+KMOD=	atavia
+SRCS=	ata-via.c
+SRCS+=  opt_ata.h ata_if.h device_if.h bus_if.h pci_if.h
+
+.include <bsd.kmod.mk>
+