Fix warnings in preparation for adding -Wall -Wcast-qual to the

        kernel compile

12 files changed, 99 insertions, 86 deletions

diff --git a/sys/miscfs/devfs/devfs_tree.c b/sys/miscfs/devfs/devfs_tree.c
index 7839645..b299051 100644
--- a/sys/miscfs/devfs/devfs_tree.c
+++ b/sys/miscfs/devfs/devfs_tree.c
@@ -24,7 +24,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  * 
- *	$Id: devfs_tree.c,v 1.57 1998/11/26 18:50:23 eivind Exp $
+ *	$Id: devfs_tree.c,v 1.58 1998/12/10 19:57:00 eivind Exp $
  */
 
 
@@ -229,8 +229,8 @@ dev_finddir(char *orig_path, dn_p dirnode, int create, dn_p *dn_pp)
 		\***************************************/
 		if(!create) return ENOENT;
 
-		if(retval = dev_add_entry(name, dirnode, DEV_DIR,
-					NULL, NULL, NULL, &devnmp)) {
+		if((retval = dev_add_entry(name, dirnode, DEV_DIR,
+					NULL, NULL, NULL, &devnmp)) != 0) {
 			return retval;
 		}
 		dnp = devnmp->dnp;
@@ -600,8 +600,8 @@ devfs_propogate(devnm_p parent,devnm_p child)
 		 * if the node already exists on that plane it won't be
 		 * re-made..
 		 */
-		if ( error = dev_add_entry(child->name, adnp, type,
-					NULL, dnp, adnp->dvm, &newnmp)) {
+		if ((error = dev_add_entry(child->name, adnp, type,
+					NULL, dnp, adnp->dvm, &newnmp)) != 0) {
 			printf("duplicating %s failed\n",child->name);
 		}
 	}
@@ -670,7 +670,7 @@ dev_dup_plane(struct devfsmount *devfs_mp_p)
 
 	DBPRINT(("	dev_dup_plane\n"));
 	if(devfs_up_and_going) {
-		if(error = dev_dup_entry(NULL, dev_root, &new, devfs_mp_p)) {
+		if((error = dev_dup_entry(NULL, dev_root, &new, devfs_mp_p)) != 0) {
 			return error;
 		}
 	} else { /* we are doing the dummy mount during initialisation.. */
@@ -726,9 +726,9 @@ dev_dup_entry(dn_p parent, devnm_p back, devnm_p *dnm_pp,
 	 * go get the node made (if we need to)
 	 * use the back one as a prototype
 	 */
-	if ( error = dev_add_entry(back->name, parent, type,
+	if ((error = dev_add_entry(back->name, parent, type,
 				NULL, dnp,
-				parent?parent->dvm:dvm, &newnmp)) {
+				parent?parent->dvm:dvm, &newnmp)) != 0) {
 		printf("duplicating %s failed\n",back->name);
 	}
 
@@ -750,8 +750,8 @@ dev_dup_entry(dn_p parent, devnm_p back, devnm_p *dnm_pp,
 		for(newback = back->dnp->by.Dir.dirlist;
 				newback; newback = newback->next)
 		{
-			if(error = dev_dup_entry(newnmp->dnp,
-						newback, &newfront, NULL))
+			if((error = dev_dup_entry(newnmp->dnp,
+					    newback, &newfront, NULL)) != 0)
 			{
 				break; /* back out with an error */
 			}
@@ -895,6 +895,8 @@ DBPRINT(("	vntodn "));
 		printf("bad-type2 (VNON)");
 		return(EINVAL);
 #endif
+	default:
+		break;
 	}
 	*dn_pp = (dn_p)vn_p->v_data;
 
@@ -980,9 +982,9 @@ DBPRINT(("(New vnode)"));
 			break;
 		case	DEV_BDEV:
 			vn_p->v_type = VBLK;
-			if (nvp = checkalias(vn_p,
+			if ((nvp = checkalias(vn_p,
 			   dnp->by.Bdev.dev,
-			  (struct mount *)0))
+			  (struct mount *)0)) != NULL)
 			{
 				vput(vn_p);
 				vn_p = nvp;
@@ -990,9 +992,9 @@ DBPRINT(("(New vnode)"));
 			break;
 		case	DEV_CDEV:
 			vn_p->v_type = VCHR;
-			if (nvp = checkalias(vn_p,
+			if ((nvp = checkalias(vn_p,
 			   dnp->by.Cdev.dev,
-			  (struct mount *)0))
+			  (struct mount *)0)) != NULL)
 			{
 				vput(vn_p);
 				vn_p = nvp;
@@ -1029,14 +1031,14 @@ dev_add_entry(char *name, dn_p parent, int type, union typeinfo *by,
 	int	error = 0;
 
 	DBPRINT(("	devfs_add_entry\n"));
-	if (error = dev_add_node(type, by, proto, &dnp, 
-			(parent?parent->dvm:dvm)))
+	if ((error = dev_add_node(type, by, proto, &dnp, 
+			(parent?parent->dvm:dvm))) != 0)
 	{
 		printf("Device %s: base node allocation failed (Errno=%d)\n",
 			name,error);
 		return error;
 	}
-	if ( error = dev_add_name(name ,parent ,NULL, dnp, nm_pp))
+	if ((error = dev_add_name(name ,parent ,NULL, dnp, nm_pp)) != 0)
 	{
 		devfs_dn_free(dnp); /* 1->0 for dir, 0->(-1) for other */
 		printf("Device %s: name slot allocation failed (Errno=%d)\n",
diff --git a/sys/miscfs/devfs/devfs_vfsops.c b/sys/miscfs/devfs/devfs_vfsops.c
index 95ae957..f3611f1 100644
--- a/sys/miscfs/devfs/devfs_vfsops.c
+++ b/sys/miscfs/devfs/devfs_vfsops.c
@@ -23,7 +23,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  * 
- *	$Id: devfs_vfsops.c,v 1.34 1998/10/31 15:31:23 peter Exp $
+ *	$Id: devfs_vfsops.c,v 1.35 1998/12/07 21:58:30 archie Exp $
  *
  */
 
@@ -129,7 +129,7 @@ DBPRINT(("mount "));
 	mp->mnt_stat.f_fsid.val[1] = mp->mnt_stat.f_type;
 	mp->mnt_flag |= MNT_LOCAL;
 
-	if(error = dev_dup_plane(devfs_mp_p))
+	if((error = dev_dup_plane(devfs_mp_p)) != 0)
 	{
 		mp->mnt_data = (qaddr_t)0;
 		free((caddr_t)devfs_mp_p, M_DEVFSMNT);
diff --git a/sys/miscfs/devfs/devfs_vnops.c b/sys/miscfs/devfs/devfs_vnops.c
index 56fa842..2f7c4ed 100644
--- a/sys/miscfs/devfs/devfs_vnops.c
+++ b/sys/miscfs/devfs/devfs_vnops.c
@@ -23,7 +23,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  * 
- *	$Id: devfs_vnops.c,v 1.65 1999/01/12 11:49:29 eivind Exp $
+ *	$Id: devfs_vnops.c,v 1.66 1999/01/21 08:29:06 dillon Exp $
  */
 
 
@@ -138,7 +138,7 @@ DBPRINT(("lookup\n"));
 	{
 		return (ENOTDIR);
 	}
-	if (error = VOP_ACCESS(dir_vnode, VEXEC, cnp->cn_cred, p))
+	if ((error = VOP_ACCESS(dir_vnode, VEXEC, cnp->cn_cred, p)) != 0)
 	{
 		return (error);
 	}
@@ -174,8 +174,8 @@ DBPRINT(("lookup\n"));
 		 * Access for write is interpreted as allowing
 		 * creation of files in the directory.
 		 */
-		if (error = VOP_ACCESS(dir_vnode, VWRITE,
-				cnp->cn_cred, p))
+		if ((error = VOP_ACCESS(dir_vnode, VWRITE,
+				cnp->cn_cred, p)) != 0)
 		{
 DBPRINT(("MKACCESS "));
 			return (error);
@@ -215,8 +215,8 @@ DBPRINT(("MKACCESS "));
 		/*
 		 * Write access to directory required to delete files.
 		 */
-		if (error = VOP_ACCESS(dir_vnode, VWRITE,
-				cnp->cn_cred, p))
+		if ((error = VOP_ACCESS(dir_vnode, VWRITE,
+				cnp->cn_cred, p)) != 0)
 			return (error);
 		/*
 		 * we are trying to delete '.'.  What does this mean? XXX
@@ -257,8 +257,8 @@ DBPRINT(("MKACCESS "));
 		/*
 		 * Are we allowed to change the holding directory?
 		 */
-		if (error = VOP_ACCESS(dir_vnode, VWRITE,
-				cnp->cn_cred, p))
+		if ((error = VOP_ACCESS(dir_vnode, VWRITE,
+				cnp->cn_cred, p)) != 0)
 			return (error);
 		/*
 		 * Careful about locking second node.
@@ -338,7 +338,7 @@ devfs_access(struct vop_access_args *ap)
 	int 	i;
 
 DBPRINT(("access\n"));
-	if (error = devfs_vntodn(vp,&file_node))
+	if ((error = devfs_vntodn(vp,&file_node)) != 0)
 	{
 		printf("devfs_vntodn returned %d ",error);
 		return error;
@@ -400,7 +400,7 @@ devfs_getattr(struct vop_getattr_args *ap)
 	int	error;
 
 DBPRINT(("getattr\n"));
-	if (error = devfs_vntodn(vp,&file_node))
+	if ((error = devfs_vntodn(vp,&file_node)) != 0)
 	{
 		printf("devfs_vntodn returned %d ",error);
 		return error;
@@ -479,7 +479,7 @@ devfs_setattr(struct vop_setattr_args *ap)
 	if (vap->va_flags != VNOVAL)	/* XXX needs to be implemented */
 		return (EOPNOTSUPP);
 
-	if (error = devfs_vntodn(vp,&file_node))
+	if ((error = devfs_vntodn(vp,&file_node)) != 0)
 	{
 		printf("devfs_vntodn returned %d ",error);
 		return error;
@@ -604,7 +604,7 @@ devfs_xread(struct vop_read_args *ap)
 	dn_p	file_node;
 
 DBPRINT(("read\n"));
-	if (error = devfs_vntodn(ap->a_vp,&file_node))
+	if ((error = devfs_vntodn(ap->a_vp,&file_node)) != 0)
 	{
 		printf("devfs_vntodn returned %d ",error);
 		return error;
@@ -678,12 +678,12 @@ DBPRINT(("remove\n"));
 	 * are the end of the path. Get pointers to all our
 	 * devfs structures.
 	 */
-	if (error = devfs_vntodn(dvp, &tdp)) {
+	if ((error = devfs_vntodn(dvp, &tdp)) != 0) {
 abortit:
 		VOP_ABORTOP(dvp, cnp); 
 		return (error);
 	}
-	if (error = devfs_vntodn(vp, &tp)) goto abortit;
+	if ((error = devfs_vntodn(vp, &tp)) != 0) goto abortit;
 	/*
 	 * Assuming we are atomic, dev_lookup left this for us
 	 */
@@ -780,8 +780,8 @@ DBPRINT(("link\n"));
 	 * are the end of the path. Get pointers to all our
 	 * devfs structures.
 	 */
-	if ( error = devfs_vntodn(tdvp,&tdp)) goto abortit;
-	if ( error = devfs_vntodn(vp,&fp)) goto abortit;
+	if ((error = devfs_vntodn(tdvp,&tdp)) != 0) goto abortit;
+	if ((error = devfs_vntodn(vp,&fp)) != 0) goto abortit;
 	
 	/*
 	 * trying to move it out of devfs? (v_tag == VT_DEVFS)
@@ -880,12 +880,12 @@ devfs_rename(struct vop_rename_args *ap)
 	 * are the end of the path. Get pointers to all our
 	 * devfs structures.
 	 */
-	if ( error = devfs_vntodn(tdvp,&tdp)) goto abortit;
-	if ( error = devfs_vntodn(fdvp,&fdp)) goto abortit;
-	if ( error = devfs_vntodn(fvp,&fp)) goto abortit;
+	if ((error = devfs_vntodn(tdvp,&tdp)) != 0) goto abortit;
+	if ((error = devfs_vntodn(fdvp,&fdp)) != 0) goto abortit;
+	if ((error = devfs_vntodn(fvp,&fp)) != 0) goto abortit;
 	fnp = fp->last_lookup;
 	if (tvp) {
-		if ( error = devfs_vntodn(tvp,&tp)) goto abortit;
+		if ((error = devfs_vntodn(tvp,&tp)) != 0) goto abortit;
 		tnp = tp->last_lookup;
 	} else {
 		tp = NULL;
@@ -1075,7 +1075,7 @@ devfs_symlink(struct vop_symlink_args *ap)
 	devnm_p nm_p;
 
 DBPRINT(("symlink\n"));
-	if(error = devfs_vntodn(ap->a_dvp, &dnp)) {
+	if((error = devfs_vntodn(ap->a_dvp, &dnp)) != 0) {
 		return (error);
 	}
 		
@@ -1083,7 +1083,7 @@ DBPRINT(("symlink\n"));
 	by.Slnk.namelen = strlen(ap->a_target);
 	dev_add_entry(ap->a_cnp->cn_nameptr, dnp, DEV_SLNK, &by,
 		NULL, NULL, &nm_p);
-	if(error = devfs_dntovn(nm_p->dnp, &vp)) {
+	if((error = devfs_dntovn(nm_p->dnp, &vp)) != 0) {
 		return (error);
 	}
 	VOP_SETATTR(vp, ap->a_vap, ap->a_cnp->cn_cred, ap->a_cnp->cn_proc);
@@ -1120,7 +1120,7 @@ devfs_readdir(struct vop_readdir_args *ap)
 DBPRINT(("readdir\n"));
 
 /*  set up refs to dir */
-	if (error = devfs_vntodn(vp,&dir_node))
+	if ((error = devfs_vntodn(vp,&dir_node)) != 0)
 		return error;
 	if(dir_node->type != DEV_DIR)
 		return(ENOTDIR);
@@ -1183,8 +1183,8 @@ DBPRINT(("readdir\n"));
 			if (uio->uio_resid < reclen) /* will it fit? */
 				break;
 			strcpy( dirent.d_name,name);
-			if (error = uiomove ((caddr_t)&dirent,
-					dirent.d_reclen, uio))
+			if ((error = uiomove ((caddr_t)&dirent,
+					dirent.d_reclen, uio)) != 0)
 				break;
 		}
 		pos += reclen;
@@ -1216,11 +1216,11 @@ devfs_readlink(struct vop_readlink_args *ap)
 
 DBPRINT(("readlink\n"));
 /*  set up refs to dir */
-	if (error = devfs_vntodn(vp,&lnk_node))
+	if ((error = devfs_vntodn(vp,&lnk_node)) != 0)
 		return error;
 	if(lnk_node->type != DEV_SLNK)
 		return(EINVAL);
-	if (error = VOP_ACCESS(vp, VREAD, ap->a_cred, NULL)) { /* XXX */
+	if ((error = VOP_ACCESS(vp, VREAD, ap->a_cred, NULL)) != 0) { /* XXX */
 		return error;
 	}
 	error = uiomove(lnk_node->by.Slnk.name, lnk_node->by.Slnk.namelen, uio);
@@ -1253,7 +1253,7 @@ devfs_reclaim(struct vop_reclaim_args *ap)
 	int	error;
 
 DBPRINT(("reclaim\n"));
-	if (error = devfs_vntodn(ap->a_vp,&file_node))
+	if ((error = devfs_vntodn(ap->a_vp,&file_node)) != 0)
 	{
 		printf("devfs_vntodn returned %d ",error);
 		return error;
@@ -1328,7 +1328,7 @@ devfs_open( struct vop_open_args *ap)
 	int error;
 	dn_p	dnp;
 
-	if (error = devfs_vntodn(vp,&dnp))
+	if ((error = devfs_vntodn(vp,&dnp)) != 0)
 		return error;
 
 	switch (vp->v_type) {
@@ -1341,13 +1341,16 @@ devfs_open( struct vop_open_args *ap)
 					p);
 		vn_lock(vp, LK_EXCLUSIVE | LK_RETRY, p);
 		return (error);
-
+		/* NOT REACHED */
 	case VBLK:
 		error = (*dnp->by.Bdev.bdevsw->d_open)(
 					dnp->by.Bdev.dev,
 					ap->a_mode,
 					S_IFBLK,
 					p);
+		break;
+	default:
+		break;
 	}
 	return (error);
 }
@@ -1379,7 +1382,7 @@ devfs_read( struct vop_read_args *ap)
 	dev_t dev;
 	dn_p	dnp;
 
-	if (error = devfs_vntodn(vp,&dnp))
+	if ((error = devfs_vntodn(vp,&dnp)) != 0)
 		return error;
 
 
@@ -1476,7 +1479,7 @@ devfs_write( struct vop_write_args *ap)
 	int error = 0;
 	dn_p	dnp;
 
-	if (error = devfs_vntodn(vp,&dnp))
+	if ((error = devfs_vntodn(vp,&dnp)) != 0)
 		return error;
 
 
@@ -1556,7 +1559,7 @@ devfs_ioctl(struct vop_ioctl_args *ap)
 	dn_p	dnp;
 	int	error;
 
-	if (error = devfs_vntodn(ap->a_vp,&dnp))
+	if ((error = devfs_vntodn(ap->a_vp,&dnp)) != 0)
 		return error;
 
 
@@ -1595,7 +1598,7 @@ devfs_poll(struct vop_poll_args *ap)
 	dn_p	dnp;
 	int	error;
 
-	if (error = devfs_vntodn(ap->a_vp,&dnp))
+	if ((error = devfs_vntodn(ap->a_vp,&dnp)) != 0)
 		return error;
 
 
@@ -1630,7 +1633,7 @@ devfs_fsync(struct vop_fsync_args *ap)
 	dn_p	dnp;
 	int	error;
 
-	if (error = devfs_vntodn(vp,&dnp))
+	if ((error = devfs_vntodn(vp,&dnp)) != 0)
 		return error;
 
 
@@ -1707,7 +1710,7 @@ devfs_strategy(struct vop_strategy_args *ap)
 	if ((ap->a_vp->v_type != VCHR)
 	&&  (ap->a_vp->v_type != VBLK))
 		panic ("devfs_strat:badvnode type");
-	if (error = devfs_vntodn(ap->a_vp,&dnp))
+	if ((error = devfs_vntodn(ap->a_vp,&dnp)) != 0)
 		return error;
 
 
@@ -1766,7 +1769,7 @@ devfs_close(struct vop_close_args *ap)
 	int error;
 	dn_p dnp;
 
-	if (error = devfs_vntodn(vp,&dnp))
+	if ((error = devfs_vntodn(vp,&dnp)) != 0)
 		return error;
 
 
@@ -1799,8 +1802,7 @@ devfs_close(struct vop_close_args *ap)
 						ap->a_fflag,
 						S_IFCHR,
 						ap->a_p));
-		break;
-
+		/* NOT REACHED */
 	case VBLK:
 		/*
 		 * On last close of a block device (that isn't mounted)
@@ -1829,7 +1831,7 @@ devfs_close(struct vop_close_args *ap)
 						ap->a_fflag,
 						S_IFBLK,
 						ap->a_p));
-
+		/* NOT REACHED */
 	default:
 		panic("devfs_close: not special");
 	}
diff --git a/sys/miscfs/fdesc/fdesc_vfsops.c b/sys/miscfs/fdesc/fdesc_vfsops.c
index 881be49..758f3b5 100644
--- a/sys/miscfs/fdesc/fdesc_vfsops.c
+++ b/sys/miscfs/fdesc/fdesc_vfsops.c
@@ -35,7 +35,7 @@
  *
  *	@(#)fdesc_vfsops.c	8.4 (Berkeley) 1/21/94
  *
- * $Id: fdesc_vfsops.c,v 1.16 1998/09/07 13:17:00 bde Exp $
+ * $Id: fdesc_vfsops.c,v 1.17 1999/01/12 11:49:30 eivind Exp $
  */
 
 /*
@@ -138,7 +138,7 @@ fdesc_unmount(mp, mntflags, p)
 	 */
 	if (rootvp->v_usecount > 1)
 		return (EBUSY);
-	if (error = vflush(mp, rootvp, flags))
+	if ((error = vflush(mp, rootvp, flags)) != 0)
 		return (error);
 
 	/*
diff --git a/sys/miscfs/fdesc/fdesc_vnops.c b/sys/miscfs/fdesc/fdesc_vnops.c
index fb8f4a1..6bdea5f 100644
--- a/sys/miscfs/fdesc/fdesc_vnops.c
+++ b/sys/miscfs/fdesc/fdesc_vnops.c
@@ -35,7 +35,7 @@
  *
  *	@(#)fdesc_vnops.c	8.9 (Berkeley) 1/21/94
  *
- * $Id: fdesc_vnops.c,v 1.39 1998/12/07 21:58:31 archie Exp $
+ * $Id: fdesc_vnops.c,v 1.40 1998/12/14 05:00:57 dillon Exp $
  */
 
 /*
@@ -283,7 +283,7 @@ fdesc_lookup(ap)
 
 	case Fdevfd:
 		if (cnp->cn_namelen == 2 && bcmp(pname, "..", 2) == 0) {
-			if (error = fdesc_root(dvp->v_mount, vpp))
+			if ((error = fdesc_root(dvp->v_mount, vpp)) != 0)
 				goto bad;
 			return (0);
 		}
diff --git a/sys/miscfs/kernfs/kernfs_vnops.c b/sys/miscfs/kernfs/kernfs_vnops.c
index 81261a9..f8ca759 100644
--- a/sys/miscfs/kernfs/kernfs_vnops.c
+++ b/sys/miscfs/kernfs/kernfs_vnops.c
@@ -34,7 +34,7 @@
  * SUCH DAMAGE.
  *
  *	@(#)kernfs_vnops.c	8.15 (Berkeley) 5/21/95
- * $Id: kernfs_vnops.c,v 1.36 1998/12/04 22:54:51 archie Exp $
+ * $Id: kernfs_vnops.c,v 1.37 1998/12/07 21:58:31 archie Exp $
  */
 
 /*
@@ -293,8 +293,8 @@ found:
 #ifdef KERNFS_DIAGNOSTIC
 	printf("kernfs_lookup: allocate new vnode\n");
 #endif
-	if (error = getnewvnode(VT_KERNFS, dvp->v_mount, kernfs_vnodeop_p,
-	    &fvp)) {
+	if ((error = getnewvnode(VT_KERNFS, dvp->v_mount, kernfs_vnodeop_p,
+	    &fvp)) != 0) {
 		vn_lock(dvp, LK_SHARED | LK_RETRY, p);
 		return (error);
 	}
@@ -466,7 +466,7 @@ kernfs_read(ap)
 #endif
 
 	len = 0;
-	if (error = kernfs_xread(kt, strbuf, sizeof(strbuf), &len))
+	if ((error = kernfs_xread(kt, strbuf, sizeof(strbuf), &len)) != 0)
 		return (error);
 	if (len <= off)
 		return (0);
@@ -497,7 +497,7 @@ kernfs_write(ap)
 		return (EINVAL);
 
 	xlen = min(uio->uio_resid, KSTRING-1);
-	if (error = uiomove(strbuf, xlen, uio))
+	if ((error = uiomove(strbuf, xlen, uio)) != 0)
 		return (error);
 
 	if (uio->uio_resid != 0)
@@ -566,7 +566,7 @@ kernfs_readdir(ap)
 		/*
 		 * And ship to userland
 		 */
-		if (error = uiomove((caddr_t)dp, UIO_MX, uio))
+		if ((error = uiomove((caddr_t)dp, UIO_MX, uio)) != 0)
 			break;
 	}
 
diff --git a/sys/miscfs/nullfs/null_vnops.c b/sys/miscfs/nullfs/null_vnops.c
index b2e1b63..514ba82 100644
--- a/sys/miscfs/nullfs/null_vnops.c
+++ b/sys/miscfs/nullfs/null_vnops.c
@@ -37,11 +37,11 @@
  *
  * Ancestors:
  *	@(#)lofs_vnops.c	1.2 (Berkeley) 6/18/92
- *	$Id: null_vnops.c,v 1.29 1998/07/04 20:45:33 julian Exp $
+ *	$Id: null_vnops.c,v 1.30 1998/12/07 21:58:32 archie Exp $
  *	...and...
  *	@(#)null_vnodeops.c 1.20 92/07/07 UCLA Ficus project
  *
- * $Id: null_vnops.c,v 1.29 1998/07/04 20:45:33 julian Exp $
+ * $Id: null_vnops.c,v 1.30 1998/12/07 21:58:32 archie Exp $
  */
 
 /*
@@ -484,6 +484,8 @@ null_access(ap)
 			if (vp->v_mount->mnt_flag & MNT_RDONLY)
 				return (EROFS);
 			break;
+		default:
+			break;
 		}
 	}
 	return (null_bypass((struct vop_generic_args *)ap));
diff --git a/sys/miscfs/procfs/procfs_subr.c b/sys/miscfs/procfs/procfs_subr.c
index 813232c..98e3687 100644
--- a/sys/miscfs/procfs/procfs_subr.c
+++ b/sys/miscfs/procfs/procfs_subr.c
@@ -36,7 +36,7 @@
  *
  *	@(#)procfs_subr.c	8.6 (Berkeley) 5/14/95
  *
- *	$Id: procfs_subr.c,v 1.21 1997/12/12 03:33:43 sef Exp $
+ *	$Id: procfs_subr.c,v 1.22 1999/01/05 03:53:06 peter Exp $
  */
 
 #include <sys/param.h>
@@ -119,7 +119,7 @@ loop:
 	 */
 	MALLOC(pfs, struct pfsnode *, sizeof(struct pfsnode), M_TEMP, M_WAITOK);
 
-	if (error = getnewvnode(VT_PROCFS, mp, procfs_vnodeop_p, vpp)) {
+	if ((error = getnewvnode(VT_PROCFS, mp, procfs_vnodeop_p, vpp)) != 0) {
 		FREE(pfs, M_TEMP);
 		goto out;
 	}
@@ -327,7 +327,7 @@ vfs_getuserstr(uio, buf, buflenp)
 		return (EMSGSIZE);
 	xlen = uio->uio_resid;
 
-	if (error = uiomove(buf, xlen, uio))
+	if ((error = uiomove(buf, xlen, uio)) != 0)
 		return (error);
 
 	/* allow multiple writes without seeks */
diff --git a/sys/miscfs/procfs/procfs_vnops.c b/sys/miscfs/procfs/procfs_vnops.c
index daab08f..1aa5453 100644
--- a/sys/miscfs/procfs/procfs_vnops.c
+++ b/sys/miscfs/procfs/procfs_vnops.c
@@ -36,7 +36,7 @@
  *
  *	@(#)procfs_vnops.c	8.18 (Berkeley) 5/21/95
  *
- *	$Id: procfs_vnops.c,v 1.62 1998/12/04 22:54:51 archie Exp $
+ *	$Id: procfs_vnops.c,v 1.63 1999/01/05 03:53:06 peter Exp $
  */
 
 /*
@@ -137,8 +137,8 @@ procfs_open(ap)
 
 	switch (pfs->pfs_type) {
 	case Pmem:
-		if ((pfs->pfs_flags & FWRITE) && (ap->a_mode & O_EXCL) ||
-		    (pfs->pfs_flags & O_EXCL) && (ap->a_mode & FWRITE))
+		if (((pfs->pfs_flags & FWRITE) && (ap->a_mode & O_EXCL)) ||
+		    ((pfs->pfs_flags & O_EXCL) && (ap->a_mode & FWRITE)))
 			return (EBUSY);
 
 		p1 = ap->a_p;
@@ -285,7 +285,7 @@ procfs_ioctl(ap)
 	case PIOCCONT:	/* Restart a proc */
 	  if (procp->p_step == 0)
 	    return EINVAL;	/* Can only start a stopped process */
-	  if (signo = *(int*)ap->a_data) {
+	  if ((signo = *(int*)ap->a_data) != 0) {
 	    if (signo >= NSIG || signo <= 0)
 	      return EINVAL;
 	    psignal(procp, signo);
@@ -847,7 +847,7 @@ procfs_readdir(ap)
 			bcopy(pt->pt_name, dp->d_name, pt->pt_namlen + 1);
 			dp->d_type = pt->pt_type;
 
-			if (error = uiomove((caddr_t)dp, UIO_MX, uio))
+			if ((error = uiomove((caddr_t)dp, UIO_MX, uio)) != 0)
 				break;
 		}
 
@@ -906,7 +906,7 @@ procfs_readdir(ap)
 				break;
 			}
 
-			if (error = uiomove((caddr_t)dp, UIO_MX, uio))
+			if ((error = uiomove((caddr_t)dp, UIO_MX, uio)) != 0)
 				break;
 		}
 	done:
diff --git a/sys/miscfs/specfs/spec_vnops.c b/sys/miscfs/specfs/spec_vnops.c
index 6096a1b..88290e4 100644
--- a/sys/miscfs/specfs/spec_vnops.c
+++ b/sys/miscfs/specfs/spec_vnops.c
@@ -31,7 +31,7 @@
  * SUCH DAMAGE.
  *
  *	@(#)spec_vnops.c	8.14 (Berkeley) 5/21/95
- * $Id: spec_vnops.c,v 1.78 1998/12/16 00:10:51 eivind Exp $
+ * $Id: spec_vnops.c,v 1.79 1999/01/21 08:29:07 dillon Exp $
  */
 
 #include <sys/param.h>
@@ -210,7 +210,7 @@ spec_open(ap)
 		error = (*cdevsw[maj]->d_open)(dev, ap->a_mode, S_IFCHR, p);
 		vn_lock(vp, LK_EXCLUSIVE | LK_RETRY, p);
 		return (error);
-
+		/* NOT REACHED */
 	case VBLK:
 		if ((u_int)maj >= nblkdev)
 			return (ENXIO);
@@ -233,6 +233,9 @@ spec_open(ap)
 		if (error)
 			return (error);
 		return ((*bdevsw[maj]->d_open)(dev, ap->a_mode, S_IFBLK, p));
+		/* NOT REACHED */
+	default:
+		break;
 	}
 	return (0);
 }
diff --git a/sys/miscfs/union/union_vfsops.c b/sys/miscfs/union/union_vfsops.c
index fb700cc..db4d4d3 100644
--- a/sys/miscfs/union/union_vfsops.c
+++ b/sys/miscfs/union/union_vfsops.c
@@ -35,7 +35,7 @@
  * SUCH DAMAGE.
  *
  *	@(#)union_vfsops.c	8.20 (Berkeley) 5/20/95
- * $Id: union_vfsops.c,v 1.29 1998/05/06 05:29:37 msmith Exp $
+ * $Id: union_vfsops.c,v 1.30 1998/09/07 13:17:02 bde Exp $
  */
 
 /*
@@ -325,7 +325,7 @@ union_unmount(mp, mntflags, p)
 	if (mntflags & MNT_FORCE)
 		flags |= FORCECLOSE;
 
-	if (error = union_root(mp, &um_rootvp))
+	if ((error = union_root(mp, &um_rootvp)) != 0)
 		return (error);
 
 	/*
diff --git a/sys/miscfs/union/union_vnops.c b/sys/miscfs/union/union_vnops.c
index 87fda6d..ba9b2a3 100644
--- a/sys/miscfs/union/union_vnops.c
+++ b/sys/miscfs/union/union_vnops.c
@@ -35,7 +35,7 @@
  * SUCH DAMAGE.
  *
  *	@(#)union_vnops.c	8.32 (Berkeley) 6/23/95
- * $Id: union_vnops.c,v 1.58 1998/07/04 20:45:35 julian Exp $
+ * $Id: union_vnops.c,v 1.59 1998/12/14 05:00:59 dillon Exp $
  */
 
 #include <sys/param.h>
@@ -695,8 +695,12 @@ union_access(ap)
 	 */
 	if (ap->a_mode & VWRITE && (ap->a_vp->v_mount->mnt_flag & MNT_RDONLY)) {
 		switch (ap->a_vp->v_type) {
-		case VREG: case VDIR: case VLNK:
+		case VREG: 
+		case VDIR:
+		case VLNK:
 			return (EROFS);
+		default:
+			break;
 		}
 	}
 	if ((vp = un->un_uppervp) != NULLVP) {