diff options
| author | dg <dg@FreeBSD.org> | 1996-06-12 03:37:57 +0000 |
|---|---|---|
| committer | dg <dg@FreeBSD.org> | 1996-06-12 03:37:57 +0000 |
| commit | 5026fc1c3662189cacaad4f0eb1fc0222ec8def1 (patch) | |
| tree | 0244ce546b0fc6e415af50b64cc8c473ae6be049 /sys/miscfs/kernfs/kernfs_vfsops.c | |
| parent | 6e349b6b4756260c2efd6d1e925c366e50db77d0 (diff) | |
| download | FreeBSD-src-5026fc1c3662189cacaad4f0eb1fc0222ec8def1.zip FreeBSD-src-5026fc1c3662189cacaad4f0eb1fc0222ec8def1.tar.gz | |
Moved the fsnode MALLOC to before the call to getnewvnode() so that the
process won't possibly block before filling in the fsnode pointer (v_data)
which might be dereferenced during a sync since the vnode is put on the
mnt_vnodelist by getnewvnode.
Pointed out by Matt Day <mday@artisoft.com>
Diffstat (limited to 'sys/miscfs/kernfs/kernfs_vfsops.c')
| -rw-r--r-- | sys/miscfs/kernfs/kernfs_vfsops.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/sys/miscfs/kernfs/kernfs_vfsops.c b/sys/miscfs/kernfs/kernfs_vfsops.c index c1ccf07..3a3e33c 100644 --- a/sys/miscfs/kernfs/kernfs_vfsops.c +++ b/sys/miscfs/kernfs/kernfs_vfsops.c @@ -34,7 +34,7 @@ * SUCH DAMAGE. * * @(#)kernfs_vfsops.c 8.4 (Berkeley) 1/21/94 - * $Id: kernfs_vfsops.c,v 1.12 1995/12/13 15:13:28 julian Exp $ + * $Id: kernfs_vfsops.c,v 1.13 1995/12/14 18:26:55 julian Exp $ */ /* @@ -165,12 +165,15 @@ kernfs_mount(mp, path, data, ndp, p) if (mp->mnt_flag & MNT_UPDATE) return (EOPNOTSUPP); + MALLOC(fmp, struct kernfs_mount *, sizeof(struct kernfs_mount), + M_UFSMNT, M_WAITOK); /* XXX */ + error = getnewvnode(VT_KERNFS, mp, kernfs_vnodeop_p, &rvp); /* XXX */ - if (error) + if (error) { + FREE(fmp, M_UFSMNT); return (error); + } - MALLOC(fmp, struct kernfs_mount *, sizeof(struct kernfs_mount), - M_UFSMNT, M_WAITOK); /* XXX */ rvp->v_type = VDIR; rvp->v_flag |= VROOT; #ifdef KERNFS_DIAGNOSTIC |
