summaryrefslogtreecommitdiffstats
path: root/sys/mips
diff options
context:
space:
mode:
authoradrian <adrian@FreeBSD.org>2012-05-04 02:26:15 +0000
committeradrian <adrian@FreeBSD.org>2012-05-04 02:26:15 +0000
commit04d9353cb2bcf7802f7cc1e934dde309a7436abb (patch)
treea50a38e6f2d645325b2b23a8da3ad5baa2ccb978 /sys/mips
parent2ba3a238daeb0647044ce72058c34540cb225fcb (diff)
downloadFreeBSD-src-04d9353cb2bcf7802f7cc1e934dde309a7436abb.zip
FreeBSD-src-04d9353cb2bcf7802f7cc1e934dde309a7436abb.tar.gz
Disable setting the MII port speed.
This seems to break at least my test board here (AR71xx + AR8316 switch PHY). Since I do have a whole sleuth of "normal" PHY boards (with an AR71xx on a normal PHY port), I'll do some further testing with those to determine whether this is a general issue, or whether it's limited to the behaviour of the "fake" dedicated PHY port mode on these atheros switches.
Diffstat (limited to 'sys/mips')
-rw-r--r--sys/mips/atheros/if_arge.c12
1 files changed, 12 insertions, 0 deletions
diff --git a/sys/mips/atheros/if_arge.c b/sys/mips/atheros/if_arge.c
index c463e1e..6c63982 100644
--- a/sys/mips/atheros/if_arge.c
+++ b/sys/mips/atheros/if_arge.c
@@ -932,7 +932,19 @@ arge_set_pll(struct arge_softc *sc, int media, int duplex)
ar71xx_device_set_pll_ge(sc->arge_mac_unit, if_speed, pll);
/* set MII registers */
+ /*
+ * This was introduced to match what the Linux ag71xx ethernet
+ * driver does. For the AR71xx case, it does set the port
+ * MII speed. However, if this is done, non-gigabit speeds
+ * are not at all reliable when speaking via RGMII through
+ * 'bridge' PHY port that's pretending to be a local PHY.
+ *
+ * Until that gets root caused, and until an AR71xx + normal
+ * PHY board is tested, leave this disabled.
+ */
+#if 0
ar71xx_device_set_mii_speed(sc->arge_mac_unit, if_speed);
+#endif
}
OpenPOWER on IntegriCloud