diff options
| author | marius <marius@FreeBSD.org> | 2011-11-22 21:28:20 +0000 |
|---|---|---|
| committer | marius <marius@FreeBSD.org> | 2011-11-22 21:28:20 +0000 |
| commit | 17e14c6132be998c8e8d0c2fc89ff0b66d24999c (patch) | |
| tree | 4941db3a873a5f9b2ccc4a64c23bf5cd65516206 /sys/mips/malta | |
| parent | 6479d45e1526c99672febf3a29a6a99305871131 (diff) | |
| download | FreeBSD-src-17e14c6132be998c8e8d0c2fc89ff0b66d24999c.zip FreeBSD-src-17e14c6132be998c8e8d0c2fc89ff0b66d24999c.tar.gz | |
- There's no need to overwrite the default device method with the default
one. Interestingly, these are actually the default for quite some time
(bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9)
since r52045) but even recently added device drivers do this unnecessarily.
Discussed with: jhb, marcel
- While at it, use DEVMETHOD_END.
Discussed with: jhb
- Also while at it, use __FBSDID.
Diffstat (limited to 'sys/mips/malta')
| -rw-r--r-- | sys/mips/malta/gt.c | 3 | ||||
| -rw-r--r-- | sys/mips/malta/gt_pci.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/sys/mips/malta/gt.c b/sys/mips/malta/gt.c index 257ac64..ce320c9 100644 --- a/sys/mips/malta/gt.c +++ b/sys/mips/malta/gt.c @@ -116,9 +116,8 @@ static device_method_t gt_methods[] = { DEVMETHOD(bus_teardown_intr, gt_teardown_intr), DEVMETHOD(bus_alloc_resource, gt_alloc_resource), DEVMETHOD(bus_activate_resource, gt_activate_resource), - DEVMETHOD(bus_print_child, bus_generic_print_child), - {0, 0}, + DEVMETHOD_END }; static driver_t gt_driver = { diff --git a/sys/mips/malta/gt_pci.c b/sys/mips/malta/gt_pci.c index aa28639..0e2012e 100644 --- a/sys/mips/malta/gt_pci.c +++ b/sys/mips/malta/gt_pci.c @@ -724,7 +724,6 @@ static device_method_t gt_pci_methods[] = { DEVMETHOD(device_resume, bus_generic_resume), /* Bus interface */ - DEVMETHOD(bus_print_child, bus_generic_print_child), DEVMETHOD(bus_read_ivar, gt_read_ivar), DEVMETHOD(bus_write_ivar, gt_write_ivar), DEVMETHOD(bus_alloc_resource, gt_pci_alloc_resource), @@ -740,7 +739,7 @@ static device_method_t gt_pci_methods[] = { DEVMETHOD(pcib_write_config, gt_pci_write_config), DEVMETHOD(pcib_route_interrupt, gt_pci_route_interrupt), - {0, 0} + DEVMETHOD_END }; static driver_t gt_pci_driver = { |
