diff options
| author | marius <marius@FreeBSD.org> | 2011-11-22 21:28:20 +0000 |
|---|---|---|
| committer | marius <marius@FreeBSD.org> | 2011-11-22 21:28:20 +0000 |
| commit | 17e14c6132be998c8e8d0c2fc89ff0b66d24999c (patch) | |
| tree | 4941db3a873a5f9b2ccc4a64c23bf5cd65516206 /sys/mips/idt | |
| parent | 6479d45e1526c99672febf3a29a6a99305871131 (diff) | |
| download | FreeBSD-src-17e14c6132be998c8e8d0c2fc89ff0b66d24999c.zip FreeBSD-src-17e14c6132be998c8e8d0c2fc89ff0b66d24999c.tar.gz | |
- There's no need to overwrite the default device method with the default
one. Interestingly, these are actually the default for quite some time
(bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9)
since r52045) but even recently added device drivers do this unnecessarily.
Discussed with: jhb, marcel
- While at it, use DEVMETHOD_END.
Discussed with: jhb
- Also while at it, use __FBSDID.
Diffstat (limited to 'sys/mips/idt')
| -rw-r--r-- | sys/mips/idt/idtpci.c | 3 | ||||
| -rw-r--r-- | sys/mips/idt/if_kr.c | 6 |
2 files changed, 2 insertions, 7 deletions
diff --git a/sys/mips/idt/idtpci.c b/sys/mips/idt/idtpci.c index 2fce32d..7e003fd 100644 --- a/sys/mips/idt/idtpci.c +++ b/sys/mips/idt/idtpci.c @@ -528,7 +528,6 @@ static device_method_t idtpci_methods[] = { DEVMETHOD(device_resume, bus_generic_resume), /* Bus interface */ - DEVMETHOD(bus_print_child, bus_generic_print_child), DEVMETHOD(bus_read_ivar, idtpci_read_ivar), DEVMETHOD(bus_write_ivar, idtpci_write_ivar), DEVMETHOD(bus_alloc_resource, idtpci_alloc_resource), @@ -544,7 +543,7 @@ static device_method_t idtpci_methods[] = { DEVMETHOD(pcib_write_config, idtpci_write_config), DEVMETHOD(pcib_route_interrupt, idtpci_route_interrupt), - {0, 0} + DEVMETHOD_END }; static driver_t idtpci_driver = { diff --git a/sys/mips/idt/if_kr.c b/sys/mips/idt/if_kr.c index 243968d..b43defa 100644 --- a/sys/mips/idt/if_kr.c +++ b/sys/mips/idt/if_kr.c @@ -118,16 +118,12 @@ static device_method_t kr_methods[] = { DEVMETHOD(device_resume, kr_resume), DEVMETHOD(device_shutdown, kr_shutdown), - /* bus interface */ - DEVMETHOD(bus_print_child, bus_generic_print_child), - DEVMETHOD(bus_driver_added, bus_generic_driver_added), - /* MII interface */ DEVMETHOD(miibus_readreg, kr_miibus_readreg), DEVMETHOD(miibus_writereg, kr_miibus_writereg), DEVMETHOD(miibus_statchg, kr_miibus_statchg), - { 0, 0 } + DEVMETHOD_END }; static driver_t kr_driver = { |
