diff options
| author | kib <kib@FreeBSD.org> | 2012-01-25 20:54:09 +0000 |
|---|---|---|
| committer | kib <kib@FreeBSD.org> | 2012-01-25 20:54:09 +0000 |
| commit | cc993a6b7525aff45c9554a479cd681d4bf2f573 (patch) | |
| tree | 80ffd5ab78c82ce54c6daaefadabb157c9ff6a7a /sys/kern | |
| parent | 6f4618881e2ec08c5c24d6a1d4a2232a956d053b (diff) | |
| download | FreeBSD-src-cc993a6b7525aff45c9554a479cd681d4bf2f573.zip FreeBSD-src-cc993a6b7525aff45c9554a479cd681d4bf2f573.tar.gz | |
When doing vflush(WRITECLOSE), clean vnode pages.
Unmounts do vfs_msync() before calling VFS_UNMOUNT(), but there is
still a race allowing a process to dirty pages after msync
finished. Remounts rw->ro just left dirty pages in system.
Reviewed by: alc, tegge (long time ago)
Tested by: pho
MFC after: 2 weeks
Diffstat (limited to 'sys/kern')
| -rw-r--r-- | sys/kern/vfs_subr.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index ee383ee..6cdd372 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -2496,6 +2496,18 @@ loop: * vnodes open for writing. */ if (flags & WRITECLOSE) { + if (vp->v_object != NULL) { + VM_OBJECT_LOCK(vp->v_object); + vm_object_page_clean(vp->v_object, 0, 0, 0); + VM_OBJECT_UNLOCK(vp->v_object); + } + error = VOP_FSYNC(vp, MNT_WAIT, td); + if (error != 0) { + VOP_UNLOCK(vp, 0); + vdrop(vp); + MNT_VNODE_FOREACH_ABORT(mp, mvp); + return (error); + } error = VOP_GETATTR(vp, &vattr, td->td_ucred); VI_LOCK(vp); |
