diff options
| author | attilio <attilio@FreeBSD.org> | 2012-01-28 14:00:21 +0000 |
|---|---|---|
| committer | attilio <attilio@FreeBSD.org> | 2012-01-28 14:00:21 +0000 |
| commit | 1521eb447956638ea699e9468527cdcbd2b28659 (patch) | |
| tree | 51e3a468764edd7cbdf62d40b3ad43948e5ccd09 /sys/kern | |
| parent | a1d2d789bd56b6e4fbadcea3ce4cab8cd7fed168 (diff) | |
| download | FreeBSD-src-1521eb447956638ea699e9468527cdcbd2b28659.zip FreeBSD-src-1521eb447956638ea699e9468527cdcbd2b28659.tar.gz | |
Avoid to check the same cache line/variable from all the locking
primitives by breaking stop_scheduler into a per-thread variable.
Also, store the new td_stopsched very close to td_*locks members as
they will be accessed mostly in the same codepaths as td_stopsched and
this results in avoiding a further cache-line pollution, possibly.
STOP_SCHEDULER() was pondered to use a new 'thread' argument, in order to
take advantage of already cached curthread, but in the end there should
not really be a performance benefit, while introducing a KPI breakage.
In collabouration with: flo
Reviewed by: avg
MFC after: 3 months (or never)
X-MFC: r228424
Diffstat (limited to 'sys/kern')
| -rw-r--r-- | sys/kern/kern_shutdown.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sys/kern/kern_shutdown.c b/sys/kern/kern_shutdown.c index 55c77c4..9da342d 100644 --- a/sys/kern/kern_shutdown.c +++ b/sys/kern/kern_shutdown.c @@ -145,7 +145,6 @@ SYSCTL_INT(_kern_shutdown, OID_AUTO, show_busybufs, CTLFLAG_RW, */ const char *panicstr; -int stop_scheduler; /* system stopped CPUs for panic */ int dumping; /* system is dumping */ int rebooting; /* system is rebooting */ static struct dumperinfo dumper; /* our selected dumper */ @@ -597,7 +596,7 @@ panic(const char *fmt, ...) * stop_scheduler_on_panic is true, then stop_scheduler will * always be set. Even if panic has been entered from kdb. */ - stop_scheduler = 1; + td->td_stopsched = 1; } #endif |
