summaryrefslogtreecommitdiffstats
path: root/sys/kern
diff options
context:
space:
mode:
authorrwatson <rwatson@FreeBSD.org>2007-04-06 23:31:30 +0000
committerrwatson <rwatson@FreeBSD.org>2007-04-06 23:31:30 +0000
commit033364d5a1dcb8651be036a2b5c2c380aac889c2 (patch)
tree4a0d4141e07a6ec69551bcaedb0e6b42d91252b3 /sys/kern
parentaf15ae34e20473e7f769fbde2bd73ff0d0fe9a82 (diff)
downloadFreeBSD-src-033364d5a1dcb8651be036a2b5c2c380aac889c2.zip
FreeBSD-src-033364d5a1dcb8651be036a2b5c2c380aac889c2.tar.gz
Remove XXX comment that changes to file fields should be protected with
the file lock rather than the filedesc lock: I fixed this in the last revision. Spotted by: kris
Diffstat (limited to 'sys/kern')
-rw-r--r--sys/kern/uipc_syscalls.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/sys/kern/uipc_syscalls.c b/sys/kern/uipc_syscalls.c
index 0c4efbf..b1ab79c 100644
--- a/sys/kern/uipc_syscalls.c
+++ b/sys/kern/uipc_syscalls.c
@@ -182,11 +182,6 @@ socket(td, uap)
if (error) {
fdclose(fdp, fp, fd, td);
} else {
- /*
- * XXXRW: The logic here seems wrong -- shouldn't it be
- * locking the file, not the filedesc? Other threads could
- * already have a reference to the socket by now.
- */
FILE_LOCK(fp);
fp->f_data = so; /* already has ref count */
fp->f_flag = FREAD|FWRITE;
OpenPOWER on IntegriCloud