diff options
| author | yar <yar@FreeBSD.org> | 2008-02-18 10:10:42 +0000 |
|---|---|---|
| committer | yar <yar@FreeBSD.org> | 2008-02-18 10:10:42 +0000 |
| commit | 2bac23abfa40043220b64d61ca13a4e2fc13cddb (patch) | |
| tree | 4972a9b1c73ab443e7fa4afd76f23f0b02709f17 /sys/kern/vfs_mount.c | |
| parent | 973784d3c349591448b29c4a54f0a14d403549e3 (diff) | |
| download | FreeBSD-src-2bac23abfa40043220b64d61ca13a4e2fc13cddb.zip FreeBSD-src-2bac23abfa40043220b64d61ca13a4e2fc13cddb.tar.gz | |
Add a remark on a questionable property of vfs_mergeopts().
Diffstat (limited to 'sys/kern/vfs_mount.c')
| -rw-r--r-- | sys/kern/vfs_mount.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/sys/kern/vfs_mount.c b/sys/kern/vfs_mount.c index 1f66a07..a494401 100644 --- a/sys/kern/vfs_mount.c +++ b/sys/kern/vfs_mount.c @@ -327,6 +327,13 @@ bad: /* * Merge the old mount options with the new ones passed * in the MNT_UPDATE case. + * + * XXX This function will keep a "nofoo" option in the + * new options if there is no matching "foo" option + * to be cancelled in the old options. This is a bug + * if the option's canonical name is "foo". E.g., "noro" + * shouldn't end up in the mount point's active options, + * but it can. */ static void vfs_mergeopts(struct vfsoptlist *toopts, struct vfsoptlist *opts) |
