diff options
| author | tegge <tegge@FreeBSD.org> | 2006-09-26 04:12:49 +0000 |
|---|---|---|
| committer | tegge <tegge@FreeBSD.org> | 2006-09-26 04:12:49 +0000 |
| commit | 83154f853d9ca39deb1add01e032aff1f0678514 (patch) | |
| tree | ac46e0b5a80f88127d3d14dc940a5f2746573c00 /sys/kern/vfs_extattr.c | |
| parent | d7fe3e736512a1dd37a985037184eecf7df1f26d (diff) | |
| download | FreeBSD-src-83154f853d9ca39deb1add01e032aff1f0678514.zip FreeBSD-src-83154f853d9ca39deb1add01e032aff1f0678514.tar.gz | |
Use mount interlock to protect all changes to mnt_flag and mnt_kern_flag.
This eliminates a race where MNT_UPDATE flag could be lost when nmount()
raced against sync(), sync_fsync() or quotactl().
Diffstat (limited to 'sys/kern/vfs_extattr.c')
| -rw-r--r-- | sys/kern/vfs_extattr.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sys/kern/vfs_extattr.c b/sys/kern/vfs_extattr.c index cbef350..147b31e 100644 --- a/sys/kern/vfs_extattr.c +++ b/sys/kern/vfs_extattr.c @@ -133,11 +133,15 @@ sync(td, uap) vfslocked = VFS_LOCK_GIANT(mp); if ((mp->mnt_flag & MNT_RDONLY) == 0 && vn_start_write(NULL, &mp, V_NOWAIT) == 0) { + MNT_ILOCK(mp); asyncflag = mp->mnt_flag & MNT_ASYNC; mp->mnt_flag &= ~MNT_ASYNC; + MNT_IUNLOCK(mp); vfs_msync(mp, MNT_NOWAIT); VFS_SYNC(mp, MNT_NOWAIT, td); + MNT_ILOCK(mp); mp->mnt_flag |= asyncflag; + MNT_IUNLOCK(mp); vn_finished_write(mp); } VFS_UNLOCK_GIANT(vfslocked); |
