diff options
author | alc <alc@FreeBSD.org> | 2010-05-02 17:33:46 +0000 |
---|---|---|
committer | alc <alc@FreeBSD.org> | 2010-05-02 17:33:46 +0000 |
commit | f35e97166b133de28351ffee3f6de3407d0272b7 (patch) | |
tree | 800dba3ed92fa905f4e1acbc91746a06e2e47bc9 /sys/kern/vfs_bio.c | |
parent | 1b4eb78965d8d551d4997edd6125fd401a212f5b (diff) | |
download | FreeBSD-src-f35e97166b133de28351ffee3f6de3407d0272b7.zip FreeBSD-src-f35e97166b133de28351ffee3f6de3407d0272b7.tar.gz |
It makes no sense for vm_page_sleep_if_busy()'s helper, vm_page_sleep(),
to unconditionally set PG_REFERENCED on a page before sleeping. In many
cases, it's perfectly ok for the page to disappear, i.e., be reclaimed by
the page daemon, before the caller to vm_page_sleep() is reawakened.
Instead, we now explicitly set PG_REFERENCED in those cases where having
the page persist until the caller is awakened is clearly desirable. Note,
however, that setting PG_REFERENCED on the page is still only a hint,
and not a guarantee that the page should persist.
Diffstat (limited to 'sys/kern/vfs_bio.c')
-rw-r--r-- | sys/kern/vfs_bio.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/sys/kern/vfs_bio.c b/sys/kern/vfs_bio.c index ea846a5..dbcd6e8 100644 --- a/sys/kern/vfs_bio.c +++ b/sys/kern/vfs_bio.c @@ -3024,8 +3024,17 @@ allocbuf(struct buf *bp, int size) * vm_fault->getpages->cluster_read->allocbuf * */ - if (vm_page_sleep_if_busy(m, FALSE, "pgtblk")) + if ((m->oflags & VPO_BUSY) != 0) { + /* + * Reference the page before unlocking + * and sleeping so that the page daemon + * is less likely to reclaim it. + */ + vm_page_lock_queues(); + vm_page_flag_set(m, PG_REFERENCED); + vm_page_sleep(m, "pgtblk"); continue; + } /* * We have a good page. |