diff options
author | rwatson <rwatson@FreeBSD.org> | 2004-06-26 17:12:29 +0000 |
---|---|---|
committer | rwatson <rwatson@FreeBSD.org> | 2004-06-26 17:12:29 +0000 |
commit | 8ecd20c6f7541f59d71ab745ffb5703c207ffd58 (patch) | |
tree | b38e804f69a3fe998ba8aac28f16ee0b90f67365 /sys/kern/uipc_socket.c | |
parent | 688c057b32d7a9576ae051edbfa127f9dfe7cdb8 (diff) | |
download | FreeBSD-src-8ecd20c6f7541f59d71ab745ffb5703c207ffd58.zip FreeBSD-src-8ecd20c6f7541f59d71ab745ffb5703c207ffd58.tar.gz |
Replace comment on spl state when calling soabort() with a comment on
locking state. No socket locks should be held when calling soabort()
as it will call into protocol code that may acquire socket locks.
Diffstat (limited to 'sys/kern/uipc_socket.c')
-rw-r--r-- | sys/kern/uipc_socket.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sys/kern/uipc_socket.c b/sys/kern/uipc_socket.c index 21ed076..16cb49e 100644 --- a/sys/kern/uipc_socket.c +++ b/sys/kern/uipc_socket.c @@ -426,7 +426,10 @@ discard: } /* - * Must be called at splnet... + * soabort() must not be called with any socket locks held, as it calls + * into the protocol, which will call back into the socket code causing + * it to acquire additional socket locks that may cause recursion or lock + * order reversals. */ int soabort(so) |