summaryrefslogtreecommitdiffstats
path: root/sys/kern/subr_vmem.c
diff options
context:
space:
mode:
authorjeff <jeff@FreeBSD.org>2013-08-19 23:02:39 +0000
committerjeff <jeff@FreeBSD.org>2013-08-19 23:02:39 +0000
commited90d4ba3f00bfbe7c9b9e97e3ff953e3c682423 (patch)
tree5ffae2b333bfbdafbb97e1341ba9715fc2bba763 /sys/kern/subr_vmem.c
parent832f853d49b1a8ff8876a53e26a39992a5ca0d57 (diff)
downloadFreeBSD-src-ed90d4ba3f00bfbe7c9b9e97e3ff953e3c682423.zip
FreeBSD-src-ed90d4ba3f00bfbe7c9b9e97e3ff953e3c682423.tar.gz
- Use an arbitrary but reasonably large import size for kva on architectures
that don't support superpages. This keeps the number of spans and internal fragmentation lower. - When the user asks for alignment from vmem_xalloc adjust the imported size by 2*align to be certain we can satisfy the allocation. This comes at the expense of potential failures when the backend can't supply enough memory but could supply the requested size and alignment. Sponsored by: EMC / Isilon Storage Division
Diffstat (limited to 'sys/kern/subr_vmem.c')
-rw-r--r--sys/kern/subr_vmem.c11
1 files changed, 9 insertions, 2 deletions
diff --git a/sys/kern/subr_vmem.c b/sys/kern/subr_vmem.c
index cff28b7..fc431e6 100644
--- a/sys/kern/subr_vmem.c
+++ b/sys/kern/subr_vmem.c
@@ -758,6 +758,7 @@ vmem_add1(vmem_t *vm, vmem_addr_t addr, vmem_size_t size, int type)
bt_t *btfree;
MPASS(type == BT_TYPE_SPAN || type == BT_TYPE_SPAN_STATIC);
+ MPASS((size & vm->vm_quantum_mask) == 0);
btspan = bt_alloc(vm);
btspan->bt_type = type;
@@ -805,7 +806,7 @@ vmem_destroy1(vmem_t *vm)
}
static int
-vmem_import(vmem_t *vm, vmem_size_t size, int flags)
+vmem_import(vmem_t *vm, vmem_size_t size, vmem_size_t align, int flags)
{
vmem_addr_t addr;
int error;
@@ -813,6 +814,12 @@ vmem_import(vmem_t *vm, vmem_size_t size, int flags)
if (vm->vm_importfn == NULL)
return EINVAL;
+ /*
+ * To make sure we get a span that meets the alignment we double it
+ * and add the size to the tail. This slightly overestimates.
+ */
+ if (align != vm->vm_quantum_mask + 1)
+ size = (align * 2) + size;
size = roundup(size, vm->vm_import_quantum);
/*
@@ -1157,7 +1164,7 @@ vmem_xalloc(vmem_t *vm, const vmem_size_t size0, vmem_size_t align,
* imported region. It is up to the user to specify the
* import quantum such that it can satisfy any allocation.
*/
- if (vmem_import(vm, size, flags) == 0)
+ if (vmem_import(vm, size, align, flags) == 0)
continue;
/*
OpenPOWER on IntegriCloud