summaryrefslogtreecommitdiffstats
path: root/sys/kern/kern_subr.c
diff options
context:
space:
mode:
authorjhb <jhb@FreeBSD.org>2000-11-16 02:16:44 +0000
committerjhb <jhb@FreeBSD.org>2000-11-16 02:16:44 +0000
commitc0bba69cbe7c4beee5213a4f1494387ee365db4c (patch)
treebc01d9302c1c47d1c7ec3254c6bfc60515318af1 /sys/kern/kern_subr.c
parent4b0f06d83c650d18d7bc905ae27eb7412fcfc038 (diff)
downloadFreeBSD-src-c0bba69cbe7c4beee5213a4f1494387ee365db4c.zip
FreeBSD-src-c0bba69cbe7c4beee5213a4f1494387ee365db4c.tar.gz
Don't release and acquire Giant in mi_switch(). Instead, release and
acquire Giant as needed in functions that call mi_switch(). The releases need to be done outside of the sched_lock to avoid potential deadlocks from trying to acquire Giant while interrupts are disabled. Submitted by: witness
Diffstat (limited to 'sys/kern/kern_subr.c')
-rw-r--r--sys/kern/kern_subr.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/sys/kern/kern_subr.c b/sys/kern/kern_subr.c
index 7c5c94a..429f34b 100644
--- a/sys/kern/kern_subr.c
+++ b/sys/kern/kern_subr.c
@@ -377,11 +377,13 @@ uio_yield()
p = curproc;
s = splhigh();
+ DROP_GIANT_NOSWITCH();
mtx_enter(&sched_lock, MTX_SPIN);
p->p_priority = p->p_usrpri;
setrunqueue(p);
p->p_stats->p_ru.ru_nivcsw++;
mi_switch();
mtx_exit(&sched_lock, MTX_SPIN);
+ PICKUP_GIANT();
splx(s);
}
OpenPOWER on IntegriCloud