diff options
| author | rwatson <rwatson@FreeBSD.org> | 2001-04-12 19:39:00 +0000 |
|---|---|---|
| committer | rwatson <rwatson@FreeBSD.org> | 2001-04-12 19:39:00 +0000 |
| commit | 6099fe82659ef526eece96d0e9df6b60bc18f889 (patch) | |
| tree | 9a7e24a207e596762895d3078eda5672c50f280f /sys/kern/kern_prot.c | |
| parent | d4d2bc9b71151966251e74d1e9a3ea5267093d0a (diff) | |
| download | FreeBSD-src-6099fe82659ef526eece96d0e9df6b60bc18f889.zip FreeBSD-src-6099fe82659ef526eece96d0e9df6b60bc18f889.tar.gz | |
o Reduce information leakage into jails by adding invocations of
p_can(...P_CAN_SEE...) to getpgid(), getsid(), and setpgid(),
blocking these operations on processes that should not be visible
by the requesting process. Required to reduce information leakage
in MAC environments.
Obtained from: TrustedBSD Project
Diffstat (limited to 'sys/kern/kern_prot.c')
| -rw-r--r-- | sys/kern/kern_prot.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/sys/kern/kern_prot.c b/sys/kern/kern_prot.c index 8db2fb6..46512d9 100644 --- a/sys/kern/kern_prot.c +++ b/sys/kern/kern_prot.c @@ -143,6 +143,7 @@ getpgid(p, uap) struct getpgid_args *uap; { struct proc *pt; + int error; pt = p; if (uap->pid == 0) @@ -150,6 +151,8 @@ getpgid(p, uap) if ((pt = pfind(uap->pid)) == 0) return ESRCH; + if ((error = p_can(p, pt, P_CAN_SEE, NULL))) + return (error); found: p->p_retval[0] = pt->p_pgrp->pg_id; return 0; @@ -170,6 +173,7 @@ getsid(p, uap) struct getsid_args *uap; { struct proc *pt; + int error; pt = p; if (uap->pid == 0) @@ -177,6 +181,8 @@ getsid(p, uap) if ((pt = pfind(uap->pid)) == 0) return ESRCH; + if ((error = p_can(p, pt, P_CAN_SEE, NULL))) + return (error); found: p->p_retval[0] = pt->p_session->s_sid; return 0; @@ -349,12 +355,15 @@ setpgid(curp, uap) { register struct proc *targp; /* target process */ register struct pgrp *pgrp; /* target pgrp */ + int error; if (uap->pgid < 0) return (EINVAL); if (uap->pid != 0 && uap->pid != curp->p_pid) { if ((targp = pfind(uap->pid)) == 0 || !inferior(targp)) return (ESRCH); + if ((error = p_can(curproc, targp, P_CAN_SEE, NULL))) + return (error); if (targp->p_pgrp == NULL || targp->p_session != curp->p_session) return (EPERM); if (targp->p_flag & P_EXEC) |
